Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement 0x1C - SHR opcode #237

Merged
merged 4 commits into from
Sep 1, 2023
Merged

feat: implement 0x1C - SHR opcode #237

merged 4 commits into from
Sep 1, 2023

Conversation

khaeljy
Copy link
Contributor

@khaeljy khaeljy commented Aug 31, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #16

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

@khaeljy khaeljy requested a review from ClementWalter as a code owner August 31, 2023 22:15
@github-actions
Copy link

Snapshot Comparison Report:

No changes in gas consumption.

enitrat
enitrat approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@enitrat enitrat added this pull request to the merge queue Sep 1, 2023
Merged via the queue into kkrt-labs:main with commit 61d1e41 Sep 1, 2023
2 checks passed
@khaeljy khaeljy deleted the SHR branch September 1, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enitrat enitrat enitrat approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: implement 0x1C - SHR opcode
2 participants
@khaeljy @enitrat