Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Trivial changes for dynamic base fee #664

Merged
merged 4 commits into from
Jun 23, 2022
Merged

Conversation

jimni1222
Copy link
Contributor

@jimni1222 jimni1222 commented Jun 22, 2022

Proposed changes

This PR includes small changes before implementation dynamic base fee in common architecture.

  • Added getHeader rpc call for caver.klay.accounts (before common architecture feature)
  • Implement _getSuggestedGasPrice for internal usage when sign via caver.klay.accounts (before common architecture feature)
  • Added caver.rpc.net.getVersion to RPC layer
  • Added effectiveGasPrice field to TransactionReceipt type
  • Modified mistypo

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

related to #662

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jimni1222 jimni1222 merged commit 38ed081 into klaytn:dev Jun 23, 2022
@jimni1222 jimni1222 deleted the dynamicBaseFee branch June 23, 2022 07:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants