Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Implementation of the dynamic base fee in common architecture features. #665

Merged
merged 5 commits into from
Jun 27, 2022

Conversation

jimni1222
Copy link
Contributor

Proposed changes

This PR introduces implementation of the dynamic base fee in common architecture features.

  • Support getSuggestedGasPrice function for transaction.
  • Set gasPrice with dynamic base fee logic in Method(RPC API).
  • Modified to use getSuggestedGasPrice instead of _klaytnCall.getGasPrice in fillTransaction function.

I can test those features when Klaytn source code is applied for this.

Note This PR includes #664, so please review #664 first.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

related to #662

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jimni1222 jimni1222 requested a review from aeharvlee as a code owner June 23, 2022 01:47
@jimni1222 jimni1222 self-assigned this Jun 23, 2022
jimni1222 and others added 2 commits June 27, 2022 16:03
Co-authored-by: Denver <aeharvlee@gmail.com>
Co-authored-by: Denver <aeharvlee@gmail.com>
@jimni1222 jimni1222 merged commit 10c0c77 into klaytn:dev Jun 27, 2022
@jimni1222 jimni1222 deleted the dbf branch June 27, 2022 08:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants