Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite: Change @asserts to errors, and change bare using Foo to using Foo: name, anothername, ... #28

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions test/script.jl
Original file line number Diff line number Diff line change
@@ -1,13 +1,28 @@
#!/usr/bin/env julia

using Distributed, SlurmClusterManager
# We don't use `using Foo` here.
# We either use `using Foo: hello, world`, or we use `import Foo`.
# https://github.com/JuliaLang/julia/pull/42080
using Distributed: addprocs, workers, nworkers, remotecall_fetch
using SlurmClusterManager: SlurmManager

addprocs(SlurmManager())

@assert nworkers() == parse(Int, ENV["SLURM_NTASKS"])
# We intentionally do not use `@assert` here.
# In a future minor release of Julia, `@assert`s may be disabled by default.
const SLURM_NTASKS = parse(Int, ENV["SLURM_NTASKS"])
if nworkers() != SLURM_NTASKS
msg = "Test failed: nworkers=$(nworkers()) does not match SLURM_NTASKS=$(SLURM_NTASKS)"
error(msg)
end

hosts = map(workers()) do id
const hosts = map(workers()) do id
remotecall_fetch(() -> gethostname(), id)
end
sort!(hosts)

@assert hosts == ["c1", "c1", "c2", "c2"]
# We don't use `@assert` here, for reason described above.
if hosts != ["c1", "c1", "c2", "c2"]
msg = "Test failed: observed_hosts=$(hosts) does not match expected_hosts=[c1, c1, c2, c2]"
error(msg)
end
Loading