Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite: Change @asserts to errors, and change bare using Foo to using Foo: name, anothername, ... #28

Merged

Conversation

DilumAluthge
Copy link
Contributor

No description provided.

@DilumAluthge
Copy link
Contributor Author

Okay, CI looks good.

@DilumAluthge
Copy link
Contributor Author

DilumAluthge commented Dec 31, 2024

@kleinhenz This one is ready for review as well. The basic idea is to implement a few best practices:

  1. In the docs for @assert, the Julia manual says, "an assert might be disabled at some optimization levels". So in this PR, I change the @asserts to explicit errors, because we never want these tests to be disabled, regardless of the optimization level.
  2. As described in JuliaLang/julia#42080, it's not ideal to do a bare using Foo. It's better (and more future-proof) to do either using Foo: hello, world, blah or import Foo. So in this PR, I remove uses of bare using Foo.
  3. I also mark as const a few variables that we expect to never change.

@DilumAluthge DilumAluthge force-pushed the dpa/change-assertions branch from a906072 to 664eacc Compare January 1, 2025 23:27
@kleinhenz kleinhenz merged commit 2fabc00 into kleinhenz:master Jan 16, 2025
4 checks passed
@DilumAluthge DilumAluthge deleted the dpa/change-assertions branch January 16, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants