Test suite: Only run the c1,c2 hostname test in CI
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
force-pushed
the
dpa/ci-hostnames
branch
from
b069bdb to
7e88517
Compare
DilumAluthge
force-pushed
the
dpa/ci-hostnames
branch
2 times, most recently
from
3fcb9fe to
7c8d28c
Compare
Also, add some debug printing to help when running the tests on a local cluster. Co-authored-by: jbphyswx <jbenjami@caltech.edu>
DilumAluthge
force-pushed
the
dpa/ci-hostnames
branch
from
7c8d28c to
b7f09cb
Compare
|
Alright, @kleinhenz this is now ready for review. @jbphyswx This should make it easier for people to run the |
kleinhenz
reviewed
Jan 17, 2025
test/script.jl
Outdated
| if hosts != ["c1", "c1", "c2", "c2"] | ||
| msg = "Test failed: observed_hosts=$(hosts) does not match expected_hosts=[c1, c1, c2, c2]" | ||
| error(msg) | ||
| const is_ci = parse(Bool, strip(get(ENV, "CI", "false"))) |
There was a problem hiding this comment.
Is this actually present in our CI since we are running inside the docker compose cluster?
There was a problem hiding this comment.
Ah, that's a really good point. No, I don't think it is.
Hmmm. I'll have to figure something else out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
@asserts to errors, and change bareusing Footousing Foo: name, anothername, ...#28