Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. After understanding how RFC6979 actually works, I'd like to propose a small change to make the PRNG in
uECC_sign_deterministic
conform to RFC6979 for those implemented curves except secp160r1, without messing withbits2octets
.In addition to two local buffers of length ~
uECC_BYTES
bytes, only one vli_ modular reduction (t <- t mod n
), onevli_nativeToBytes
function call, and onevli_bytesToNative
function call must need to be added. I think the increase in signing time and code size is negligible.