Fix a logic error in deterministic PRNG with buffer overrun issue #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
uECC_sign_deterministic
, whenuECC_WORD_SIZE
is 8, the array declaration for T becomesuint64_t T[3];
and the following codebecomes
I think that is not what we want (to keep only 161 pseudo-random bits so that 0 <= k <= 2^161-1) and the code in that case should be
The entire code block may be changed into something like this: