段落ブロックの末尾空行を取ってから段落生成 #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahashim
reviewed
Dec 12, 2017
lib/review/textutils.rb
Outdated
| @@ -15,6 +15,7 @@ def detab(str, ts = 8) | |||
| def split_paragraph(lines) | |||
| pre = pre_paragraph | |||
| post = post_paragraph | |||
| lines.pop while lines[lines.size - 1] && lines[lines.size - 1].strip.empty? | |||
There was a problem hiding this comment.
これは元のlinesに破壊的変更を加えるべきではなくて、blocked_linesの方で不要な空行を削るべきなのではないでしょうか…？
There was a problem hiding this comment.
split_paragraph呼んでるところがバラバラなのと、blocked_linesのほうはともかく取り込むというスタンスになってるっぽいんだよねぇ。ちなみに//emlistなどの場合は末尾空行群はこれとは別にまとめて削除してるようだ
do not break argument `lines`
|
1行whileか…いちおrubocopさんに従ってみる |
|
まじですか、そのrubocopのルールはナイですね… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#882 の修正