Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leader election patch #301

Closed
pierDipi opened this issue Oct 15, 2020 · 2 comments
Closed

Remove leader election patch #301

pierDipi opened this issue Oct 15, 2020 · 2 comments
Assignees
@arghya88
Labels
area/release lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@pierDipi
Copy link
Member

See #293 (comment)

We should monitor upstream fixes: kubernetes/kubernetes#91942

/lifecycle frozen
@knative-prow-robot knative-prow-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 15, 2020
@pierDipi pierDipi changed the title Leader election patch Remove leader election patch Oct 15, 2020
@pierDipi
Copy link
Member Author

pierDipi commented Dec 9, 2020

This was done by @arghya88 in #449.
/assign arghya88
/area release
/close

@knative-prow-robot
Copy link
Contributor

@pierDipi: Closing this issue.

In response to this:

This was done by @arghya88 in #449.
/assign arghya88
/area release
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierDipi pushed a commit to pierDipi/eventing-kafka-broker that referenced this issue Jun 16, 2022
@aliok
Fallback mechanism for the old external topic annotation for broker (k…
7b58495 
…native-extensions#301)
matzew pushed a commit to matzew/eventing-kafka-broker that referenced this issue Jun 20, 2022
@aliok @matzew
Fallback mechanism for the old external topic annotation for broker (k…
97e4933 
…native-extensions#301)
pierDipi pushed a commit to pierDipi/eventing-kafka-broker that referenced this issue Jun 21, 2022
@matzew @aliok
[release-v1.3] External topic backport ocp (knative-extensions#305)
4ab8c99 
* Annotation for external topics

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* 💄 we want this as a real feature, removing the 'x-' flag

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Fallback mechanism for the old external topic annotation for broker (knative-extensions#301)

Co-authored-by: Ali Ok <aliok@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arghya88 arghya88

Labels
area/release lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arghya88 @pierDipi @knative-prow-robot