Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Automated] Update actions #305

Merged
merged 1 commit into from
Oct 16, 2020
Merged

[Automated] Update actions #305

merged 1 commit into from
Oct 16, 2020

Conversation

mattmoor
Copy link
Contributor

Produced via:

# meta: knative-sandbox/.github
# main: knative-sandbox/eventing-kafka-broker
cp $(find "${GITHUB_WORKSPACE}/meta/workflow-templates" -type f -name '*.yaml') \
  "${GITHUB_WORKSPACE}/main/.github/workflows/"

/cc slinkydeveloper
/assign slinkydeveloper

@mattmoor
Update common github actions
ab49280 
Signed-off-by: Matt Moore (via Sockpuppet) <mattmoor@vmware.com>
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2020
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 16, 2020
@codecov
Copy link

codecov bot commented Oct 16, 2020 •
edited
Loading

Codecov Report

Merging #305 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #305   +/-   ##
=========================================
  Coverage     76.27%   76.27%           
  Complexity      176      176           
=========================================
  Files            49       49           
  Lines          1505     1505           
  Branches         47       47           
=========================================
  Hits           1148     1148           
  Misses          285      285           
  Partials         72       72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb06c96...ab49280. Read the comment docs.

pierDipi
pierDipi approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit c4f0864 into knative-extensions:master Oct 16, 2020
pierDipi pushed a commit to pierDipi/eventing-kafka-broker that referenced this pull request Oct 19, 2020
@mattmoor @pierDipi
Update common github actions (knative-extensions#305)
80e937f 
Signed-off-by: Matt Moore (via Sockpuppet) <mattmoor@vmware.com>
pierDipi pushed a commit to pierDipi/eventing-kafka-broker that referenced this pull request Jun 21, 2022
@matzew @aliok
[release-v1.3] External topic backport ocp (knative-extensions#305)
4ab8c99 
* Annotation for external topics

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* 💄 we want this as a real feature, removing the 'x-' flag

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Fallback mechanism for the old external topic annotation for broker (knative-extensions#301)

Co-authored-by: Ali Ok <aliok@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

Assignees

@slinkydeveloper slinkydeveloper

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattmoor @knative-prow-robot @pierDipi @slinkydeveloper