Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[control-plane] List applying policies in KafkaSinks .status.policies #4039

Closed
creydr opened this issue Aug 7, 2024 · 4 comments · Fixed by #4084
Closed

[control-plane] List applying policies in KafkaSinks .status.policies #4039

creydr opened this issue Aug 7, 2024 · 4 comments · Fixed by #4084
Assignees
Labels
area/control-plane help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)

Comments

@creydr
Copy link
Contributor

creydr commented Aug 7, 2024

As the Eventing Authorization feature track describes, target resources of EventPolicies, will reflect in their status, which EventPolicy is applied to them.

For example:

apiVersion: kafkasinks.eventing.knative.dev
kind: KafkaSink
metadata:
  name: my-sink
spec:
  ...
status:
  ...
  policies:
    - name: event-policy
      apiVersion: v1alpha1
    - name: another-event-policy
      apiVersion: v1alpha1

  conditions:
    - type: Ready
      status: "True"
    - type: EventPoliciesReady
      status: "True"

As the KafkaSink should support EventPolicies, wee need to do the following:

  • Update the KafkaSink reconciler to show applying policies in the KafkaSinks .status.policies and set the KafkaSinks EventPoliciesReady condition. Also watch EventPolicies for changes.
  • Set EventPoliciesReady condition to true, in case no policy applies, and set message according to the default-authorization-mode (e.g. Default authorization mode is 'allow-all'). Check the Default Authorization Mode section in the feature track for additional information.

Hints:

Additional hints for new contributors before starting with this issue:

  1. When the issue has the Draft status, the issue is subject to change and thus should not be started to be worked on
  2. Make sure you've read and understood the CONTRIBUTING.md guidelines
  3. Make sure you're able to run Knative Eventing locally with Knative Eventing Kafka and run at least the unit tests.
  4. Feel free to raise any questions you have either directly here in the issue, in the #knative-eventing Slack channel or join the Eventing Workgroup Meeting / Office Hours
  5. When you feel comfortable with this issue, feel free to assign it to you (e.g. by commenting /assign). Please be aware that we might unassign you, if we don't see any progress from your side to give other contributors also a chance to work on this issue.
@creydr
Copy link
Contributor Author

creydr commented Aug 7, 2024

/help
/triage accepted

Copy link

knative-prow bot commented Aug 7, 2024

@creydr:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added triage/accepted Issues which should be fixed (post-triage) help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 7, 2024
@creydr creydr moved this from 📝 Draft to 🔖 Ready in Eventing Authorization Aug 12, 2024
@Cali0707
Copy link
Member

/area control-plane

@creydr
Copy link
Contributor Author

creydr commented Aug 26, 2024

/assign

@creydr creydr moved this from 🔖 Ready to 🏗 In progress in Eventing Authorization Aug 26, 2024
@creydr creydr moved this from 🏗 In progress to 👀 In review in Eventing Authorization Aug 26, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Eventing Authorization Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants