Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List applying EventPolicies in KafkaSink #4084

Merged
merged 7 commits into from
Aug 30, 2024
Merged

List applying EventPolicies in KafkaSink #4084

merged 7 commits into from
Aug 30, 2024

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Aug 26, 2024

Fixes #4039

Proposed Changes

  • 🎁 List applying EventPolicies in KafkaSink

Release Note

List applying EventPolicies in KafkaSink

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 26, 2024
@creydr
Copy link
Contributor Author

creydr commented Aug 26, 2024

/cc @pierDipi @matzew

@knative-prow knative-prow bot requested review from matzew and pierDipi August 26, 2024 13:23
@codecov Codecov
Copy link

codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.61194% with 15 lines in your changes missing coverage. Please review.

Project coverage is 48.46%. Comparing base (241e6a7) to head (b82fc72).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pkg/apis/eventing/v1alpha1/kafka_sink_lifecycle.go 0.00% 8 Missing ⚠️
control-plane/pkg/reconciler/sink/kafka_sink.go 66.66% 2 Missing and 2 partials ⚠️
control-plane/pkg/reconciler/broker/broker.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4084      +/-   ##
==========================================
+ Coverage   48.43%   48.46%   +0.02%     
==========================================
  Files         244      244              
  Lines       14767    14785      +18     
==========================================
+ Hits         7153     7165      +12     
- Misses       6901     6908       +7     
+ Partials      713      712       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi pierDipi changed the title List applying EventPolicies in KafkaSink [WIP] List applying EventPolicies in KafkaSink Aug 27, 2024
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
@creydr creydr force-pushed the list-applying-policies-in-kafkasink branch from c526e8c to a7f6706 Compare August 28, 2024 07:46
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2024
@creydr creydr changed the title [WIP] List applying EventPolicies in KafkaSink List applying EventPolicies in KafkaSink Aug 28, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2024
@creydr
Copy link
Contributor Author

creydr commented Aug 28, 2024

@pierDipi this is ready for review

@creydr
Copy link
Contributor Author

creydr commented Aug 28, 2024

/retest

@creydr creydr force-pushed the list-applying-policies-in-kafkasink branch from 4ffff7f to 2aca0e5 Compare August 28, 2024 14:44
@creydr
Copy link
Contributor Author

creydr commented Aug 28, 2024

/test upgrade-tests

@creydr
Copy link
Contributor Author

creydr commented Aug 28, 2024

/retest

@creydr
Copy link
Contributor Author

creydr commented Aug 29, 2024

@pierDipi can you recheck?

@creydr creydr requested a review from pierDipi August 29, 2024 10:14
@creydr
Copy link
Contributor Author

creydr commented Aug 29, 2024

@pierDipi could you recheck?

pierDipi
pierDipi approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 5825486 into knative-extensions:main Aug 30, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@matzew matzew Awaiting requested review from matzew

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[control-plane] List applying policies in KafkaSinks .status.policies
2 participants
@creydr @pierDipi