Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save release artifacts only after building from source #1308

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Oct 13, 2021

save_release_artifacts assumes that we have built
artifacts from source, I want to run tests without building
from source code.

SKIP_INITIALIZE is the variable used to skip building
the project from source and bootstrapping a cluster.

/cc @aliok @matzew

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 13, 2021
@knative-prow-robot knative-prow-robot added area/test approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2021
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #1308 (5978b31) into main (d24282d) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1308      +/-   ##
============================================
- Coverage     75.67%   75.64%   -0.04%     
+ Complexity      460      459       -1     
============================================
  Files            87       87              
  Lines          3059     3059              
  Branches        136      136              
============================================
- Hits           2315     2314       -1     
- Misses          580      581       +1     
  Partials        164      164              
Flag Coverage Δ
java-unittests 79.98% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dispatcher/impl/consumer/BaseConsumerVerticle.java 89.28% <0.00%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d24282d...5978b31. Read the comment docs.

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Contributor

matzew commented Oct 13, 2021

/test pull-knative-sandbox-eventing-kafka-broker-build-tests

@knative-prow-robot knative-prow-robot merged commit 3ab1cb1 into knative-extensions:main Oct 13, 2021
@pierDipi pierDipi deleted the KNATIVE-save-release-artifacts-only-after-build branch October 13, 2021 13:30
@pierDipi
Copy link
Member Author

/cherry-pick release-0.26

@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #1453

In response to this:

/cherry-pick release-0.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants