Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.26] Save release artifacts only after building from source #1453

Merged
merged 1 commit into from
Nov 10, 2021
Merged

[release-0.26] Save release artifacts only after building from source #1453

merged 1 commit into from
Nov 10, 2021

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #1308

@pierDipi @knative-prow-robot
Save release artifacts only after building from source
746468d 
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
@knative-prow-robot knative-prow-robot mentioned this pull request Nov 10, 2021
Merged
@knative-prow-robot knative-prow-robot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 10, 2021
@knative-prow-robot knative-prow-robot added area/test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 10, 2021
@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021 •
edited
Loading

Codecov Report

Merging #1453 (746468d) into release-0.26 (cbd8c28) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##             release-0.26    #1453      +/-   ##
==================================================
- Coverage           75.70%   75.68%   -0.03%     
  Complexity            460      460              
==================================================
  Files                  87       86       -1     
  Lines                3058     3051       -7     
  Branches              136      136              
==================================================
- Hits                 2315     2309       -6     
+ Misses                579      578       -1     
  Partials              164      164
Flag Coverage Δ
java-unittests 80.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
control-plane/pkg/config/env_config.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd8c28...746468d. Read the comment docs.

pierDipi
pierDipi approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@knative-prow-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 897f426 into knative-extensions:release-0.26 Nov 10, 2021
pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request Nov 12, 2021
@knative-prow-robot @pierDipi
Save release artifacts only after building from source (knative-exten…
ef8408e 
…sions#1453)

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

Co-authored-by: Pierangelo Di Pilato <pdipilat@redhat.com>
pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request Nov 12, 2021
@knative-prow-robot @pierDipi
Save release artifacts only after building from source (knative-exten…
a753d06 
…sions#1453)

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

Co-authored-by: Pierangelo Di Pilato <pdipilat@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knative-prow-robot @pierDipi