Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sarama version to v1.29.1 #1424

Conversation

odacremolbap
Copy link

Fixes #1421

Workarond sticks to Samara v1.29.1 so that Knative tests do not fail.
This is not intended to be permanent and should be removed when a PR akin to this gets merged.

There is also an update of the kn/hack repo which I don't think is strictly needed here, but will resolve tags from knative-v1.0.0 and on for any test that needs it.

Proposed Changes

  • Pin the samara version to v1.29.1. Will need to be unpinned when it is upgraded at this repo.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 7, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: odacremolbap
To complete the pull request process, please assign devguyio after the PR has been reviewed.
You can assign the PR to them by writing /assign @devguyio in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2021
@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #1424 (06b71c1) into main (141ddb8) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1424      +/-   ##
============================================
- Coverage     71.46%   71.41%   -0.06%     
  Complexity      584      584              
============================================
  Files           100      100              
  Lines          3964     3964              
  Branches        166      166              
============================================
- Hits           2833     2831       -2     
  Misses          915      915              
- Partials        216      218       +2     
Flag Coverage Δ
java-unittests 82.28% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/eventing/kafka/broker/core/file/FileWatcher.java 75.64% <0.00%> (-5.13%) ⬇️
...dispatcher/impl/consumer/BaseConsumerVerticle.java 93.10% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 141ddb8...06b71c1. Read the comment docs.

@odacremolbap
Copy link
Author

/assign @devguyio

@odacremolbap
Copy link
Author

/retest

@pierDipi
Copy link
Member

pierDipi commented Nov 8, 2021

Hi @odacremolbap, I sent a PR to bump Sarama to 1.30 #1435

@odacremolbap
Copy link
Author

Thanks so much @pierDipi
Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to upgrade Sarama To v1.30.0
4 participants