This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Upgrade Sarama To v0.30.0 #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
approved
Codecov Report
@@ Coverage Diff @@
## main #975 +/- ##
=======================================
Coverage 75.02% 75.02%
=======================================
Files 121 121
Lines 5650 5650
=======================================
Hits 4239 4239
Misses 1188 1188
Partials 223 223 Continue to review full report at Codecov.
|
|
/test pull-knative-sandbox-eventing-kafka-upgrade-tests |
matzew
approved these changes
Nov 8, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, travis-minke-sap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general we want to keep up with Sarama Kafka Client library dependencies. Specifically not being up to date was causing problems for eventing e2e tests (see PR #972)
Proposed Changes
ApiVersionsRequestresponse