Receiver handles ingress probes #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
area/data-plane
size/L
pierDipi
changed the title
knative-prow-robot
added
the
do-not-merge/work-in-progress
Codecov Report
@@ Coverage Diff @@
## main #1431 +/- ##
============================================
+ Coverage 71.41% 73.41% +1.99%
+ Complexity 584 581 -3
============================================
Files 100 101 +1
Lines 3964 3949 -15
Branches 166 164 -2
============================================
+ Hits 2831 2899 +68
+ Misses 915 810 -105
- Partials 218 240 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pierDipi
force-pushed
the
SRVKE-957_Data-plane-probe-handling
branch
from
7f324c3 to
6793983
Compare
Probing is done using the knative/networking data-plane contract (already implemented in Eventing through knative/pkg). ref issue knative/eventing#3911 Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
pierDipi
force-pushed
the
SRVKE-957_Data-plane-probe-handling
branch
from
6793983 to
e19b137
Compare
pierDipi
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
matzew
reviewed
Nov 9, 2021
...in/java/dev/knative/eventing/kafka/broker/receiver/impl/handler/MethodNotAllowedHandler.java
Outdated
Show resolved
Hide resolved
matzew
reviewed
Nov 9, 2021
.../src/main/java/dev/knative/eventing/kafka/broker/receiver/impl/handler/ProbeRequestUtil.java
Outdated
Show resolved
Hide resolved
.../src/main/java/dev/knative/eventing/kafka/broker/receiver/impl/handler/ProbeRequestUtil.java
Outdated
Show resolved
Hide resolved
matzew
requested changes
Nov 9, 2021
.../src/main/java/dev/knative/eventing/kafka/broker/receiver/impl/handler/ProbeRequestUtil.java
Outdated
Show resolved
Hide resolved
.../src/main/java/dev/knative/eventing/kafka/broker/receiver/impl/handler/ProbeRequestUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
pierDipi
force-pushed
the
SRVKE-957_Data-plane-probe-handling
branch
from
63cc43d to
e0de981
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probing is done using the knative/networking data-plane contract
(already implemented in Eventing through knative/pkg).
ref issue knative/eventing#3911
This is part of our work to reduce e2e tests' flakiness.
Proposed Changes
Release Note
Docs