Set KafkaChannel delivery order to ordered by default #1438
Conversation
The existing channel uses ordered delivery and I think we should keep it ordered by default for the new channel for backward compatibility and seamless upgrade. Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
knative-prow-robot
added
approved
Codecov Report
@@ Coverage Diff @@
## main #1438 +/- ##
============================================
- Coverage 73.41% 73.34% -0.07%
Complexity 575 575
============================================
Files 100 100
Lines 3942 3943 +1
Branches 160 160
============================================
- Hits 2894 2892 -2
- Misses 808 811 +3
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -447,6 +448,7 @@ func (r *Reconciler) getSubscriberConfig(ctx context.Context, channel *messaging | |||
| egress := &contract.Egress{ | |||
| Destination: subscriber.SubscriberURI.String(), | |||
| ConsumerGroup: consumerGroup(channel, subscriber), | |||
| DeliveryOrder: contract.DeliveryOrder_ORDERED, | |||
There was a problem hiding this comment.
perhaps.... not sure it really makes sense, but:
is that a change from the other KafkaChannels?
There was a problem hiding this comment.
I'm not following what do you mean here.
There was a problem hiding this comment.
I also am not sure about the behaviour of delivery order in KafkaChannel implementations.
There was a problem hiding this comment.
is the eventing-kafka unordered ?
There was a problem hiding this comment.
eventing-kafka is ordered (only)
knative-prow-robot
added
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The existing channel uses ordered delivery and I think we should
keep it ordered by default for the new channel for backward
compatibility and seamless upgrade.
Proposed Changes
Release Note
Docs