Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set KafkaChannel delivery order to ordered by default #1438

Merged
merged 4 commits into from
Nov 11, 2021
Merged

Set KafkaChannel delivery order to ordered by default #1438

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0f3b3e
Set KafkaChannel delivery order to ordered by default
pierDipi Nov 8, 2021
212bdbd
Merge branch 'main' into SRVKE-1026_KafkaChannel-default-delivery-order
pierDipi Nov 10, 2021
b3fb977
Update channel.go
pierDipi Nov 10, 2021
39496b1
Update channel.go
pierDipi Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions control-plane/pkg/reconciler/channel/channel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,7 @@ func (r *Reconciler) getSubscriberConfig(ctx context.Context, channel *messaging
egress := &contract.Egress{
Destination: subscriber.SubscriberURI.String(),
ConsumerGroup: consumerGroup(channel, subscriber),
DeliveryOrder: contract.DeliveryOrder_ORDERED,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps.... not sure it really makes sense, but:

https://github.com/knative-sandbox/eventing-kafka-broker/blob/d3815d268fb6dd3d2a39c3043ea8606232a2165a/control-plane/pkg/reconciler/source/source.go#L50-L52

is that a change from the other KafkaChannels?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not following what do you mean here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also am not sure about the behaviour of delivery order in KafkaChannel implementations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the eventing-kafka unordered ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventing-kafka is ordered (only)

Uid: string(subscriber.UID),
}

Expand Down