Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Trigger Reconciler for ConsumerGroup scaling #1566

Conversation

aavarghese
Copy link
Contributor

@aavarghese aavarghese commented Dec 2, 2021

See #1569

Proposed Changes

Release Note


Docs

aavarghese and others added 3 commits December 2, 2021 13:54
Signed-off-by: aavarghese <avarghese@us.ibm.com>
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
Signed-off-by: aavarghese <avarghese@us.ibm.com>
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 2, 2021
@knative-prow-robot knative-prow-robot added area/control-plane size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 2, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aavarghese
To complete the pull request process, please assign rhuss after the PR has been reviewed.
You can assign the PR to them by writing /assign @rhuss in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #1566 (2a05b05) into main (7064e01) will increase coverage by 6.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1566      +/-   ##
============================================
+ Coverage     75.33%   82.06%   +6.73%     
+ Complexity      593      592       -1     
============================================
  Files           107       66      -41     
  Lines          4135     1924    -2211     
  Branches        170      170              
============================================
- Hits           3115     1579    -1536     
+ Misses          764      255     -509     
+ Partials        256       90     -166     
Flag Coverage Δ
java-unittests 82.06% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/eventing/kafka/broker/core/file/FileWatcher.java 75.64% <0.00%> (-5.13%) ⬇️
control-plane/pkg/reconciler/trigger/controller.go
control-plane/pkg/reconciler/trigger/trigger.go
...-plane/pkg/reconciler/trigger/trigger_lifecycle.go
...pkg/apis/eventing/v1alpha1/kafka_sink_lifecycle.go
control-plane/pkg/security/scram.go
control-plane/pkg/reconciler/kafka/broker_class.go
control-plane/pkg/reconciler/kafka/topic.go
...ntrol-plane/pkg/apis/eventing/v1alpha1/register.go
control-plane/pkg/reconciler/base/reconciler.go
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7064e01...2a05b05. Read the comment docs.

@knative-prow-robot
Copy link
Contributor

@aavarghese: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-knative-sandbox-eventing-kafka-broker-unit-tests 2a05b05 link true /test pull-knative-sandbox-eventing-kafka-broker-unit-tests
pull-knative-sandbox-eventing-kafka-broker-go-coverage 2a05b05 link false /test pull-knative-sandbox-eventing-kafka-broker-go-coverage
pull-knative-sandbox-eventing-kafka-broker-upgrade-tests 2a05b05 link true /test pull-knative-sandbox-eventing-kafka-broker-upgrade-tests
pull-knative-sandbox-eventing-kafka-broker-integration-tests 2a05b05 link true /test pull-knative-sandbox-eventing-kafka-broker-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aavarghese aavarghese closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants