Trigger Reconciler for ConsumerGroup scaling

[aavarghese]

Part of #1537 (triggerv2_test.go coming soon)

Proposed Changes

• Adding new Trigger reconciler to create ConsumerGroup resources

Release Note

Docs

[codecov]

Codecov Report

Merging #1569 (96fc294) into main (6551287) will decrease coverage by 1.73%.
The diff coverage is 20.71%.

@@             Coverage Diff              @@
##               main    #1569      +/-   ##
============================================
- Coverage     74.87%   73.13%   -1.74%     
  Complexity      595      595              
============================================
  Files           116      118       +2     
  Lines          4211     4348     +137     
  Branches        171      171              
============================================
+ Hits           3153     3180      +27     
- Misses          802      909     +107     
- Partials        256      259       +3     

Flag	Coverage Δ
java-unittests	81.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ls/kafka/eventing/v1alpha1/consumer_group_types.go	0.00% <ø> (ø)
...nternals/kafka/eventing/v1alpha1/consumer_types.go	0.00% <ø> (ø)
...ntrol-plane/pkg/reconciler/trigger/v2/triggerv2.go	0.00% <0.00%> (ø)
...ol-plane/pkg/reconciler/trigger/v2/controllerv2.go	50.00% <50.00%> (ø)
control-plane/pkg/reconciler/trigger/trigger.go	70.83% <66.66%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6551287...96fc294. Read the comment docs.

[pierDipi]

We should create a new Trigger reconciler rather than changing the existing one since the logic is completely different between the 2.

[pierDipi]

Ideally, we should get topics from the broker status.

[aavarghese]

Sure - will add in my next iteration along with unit test

[pierDipi]

We should also set bootstrap.servers that we, ideally, get from the broker status.

[aavarghese]

Same as above

[pierDipi]

/lgtm

=== RUN   TestNewControllerV2
    logger.go:130: 2021-12-10T13:32:17.206Z	PANIC	dynamicclient/dynamicclient.go:45	Unable to fetch k8s.io/client-go/dynamic.Interface from context.
--- FAIL: TestNewControllerV2 (0.00s)
panic: Unable to fetch k8s.io/client-go/dynamic.Interface from context. [recovered]
	panic: Unable to fetch k8s.io/client-go/dynamic.Interface from context.

goroutine 13 [running]:
testing.tRunner.func1.2({0x23c4120, 0xc0000afa00})
	/root/.gvm/gos/go1.17.2/src/testing/testing.go:1209 +0x36c
testing.tRunner.func1()
	/root/.gvm/gos/go1.17.2/src/testing/testing.go:1212 +0x3b6
panic({0x23c4120, 0xc0000afa00})
	/root/.gvm/gos/go1.17.2/src/runtime/panic.go:1047 +0x266
go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc000241080, {0x0, 0x0, 0x0})
	/home/prow/go/src/knative.dev/eventing-kafka-broker/vendor/go.uber.org/zap/zapcore/entry.go:232 +0x5e9
go.uber.org/zap.(*SugaredLogger).log(0xc00061c350, 0x4, {0x0, 0x0}, {0xc00031dc08, 0x1, 0x1}, {0x0, 0x0, 0x0})
	/home/prow/go/src/knative.dev/eventing-kafka-broker/vendor/go.uber.org/zap/sugar.go:227 +0x13b
go.uber.org/zap.(*SugaredLogger).Panic(...)
	/home/prow/go/src/knative.dev/eventing-kafka-broker/vendor/go.uber.org/zap/sugar.go:123
knative.dev/pkg/injection/clients/dynamicclient.Get({0x2c7a660, 0xc000185c20})
	/home/prow/go/src/knative.dev/eventing-kafka-broker/vendor/knative.dev/pkg/injection/clients/dynamicclient/dynamicclient.go:45 +0xfc
knative.dev/pkg/client/injection/ducks/duck/v1/addressable.WithDuck({0x2c7a660, 0xc000185c20})
	/home/prow/go/src/knative.dev/eventing-kafka-broker/vendor/knative.dev/pkg/client/injection/ducks/duck/v1/addressable/addressable.go:40 +0x5a
knative.dev/pkg/injection.(*impl).SetupInformers(0x2c7a5b8, {0x2c7a660, 0xc000185710}, 0x3c7d410)
	/home/prow/go/src/knative.dev/eventing-kafka-broker/vendor/knative.dev/pkg/injection/informers.go:116 +0x1ef
knative.dev/pkg/reconciler/testing.SetupFakeContextWithCancel({0x2cd11d0, 0xc000627a00}, {0x0, 0x0, 0xc0000abe78})
	/home/prow/go/src/knative.dev/eventing-kafka-broker/vendor/knative.dev/pkg/reconciler/testing/context.go:57 +0x238
knative.dev/pkg/reconciler/testing.SetupFakeContext(...)
	/home/prow/go/src/knative.dev/eventing-kafka-broker/vendor/knative.dev/pkg/reconciler/testing/context.go:44
knative.dev/eventing-kafka-broker/control-plane/pkg/reconciler/trigger/v2.TestNewControllerV2(0xc000627a00)
	/home/prow/go/src/knative.dev/eventing-kafka-broker/control-plane/pkg/reconciler/trigger/v2/controllerv2_test.go:36 +0x45
testing.tRunner(0xc000627a00, 0x27bd1e0)
	/root/.gvm/gos/go1.17.2/src/testing/testing.go:1259 +0x230
created by testing.(*T).Run
	/root/.gvm/gos/go1.17.2/src/testing/testing.go:1306 +0x727

We can merge this once the test is fixed.

[pierDipi]

This should be the fix:

diff --git a/control-plane/pkg/reconciler/trigger/v2/controllerv2_test.go b/control-plane/pkg/reconciler/trigger/v2/controllerv2_test.go
index 5bb5a0a0..0f2edc46 100644
--- a/control-plane/pkg/reconciler/trigger/v2/controllerv2_test.go
+++ b/control-plane/pkg/reconciler/trigger/v2/controllerv2_test.go
@@ -21,14 +21,15 @@ import (
 
        reconcilertesting "knative.dev/pkg/reconciler/testing"
 
-       _ "knative.dev/eventing-kafka-broker/control-plane/pkg/client/internals/kafka/injection/informers/eventing/v1alpha1/consumergroup/fake"
        _ "knative.dev/eventing/pkg/client/injection/informers/eventing/v1/broker/fake"
        _ "knative.dev/eventing/pkg/client/injection/informers/eventing/v1/trigger/fake"
-       _ "knative.dev/pkg/client/injection/ducks/duck/v1/addressable/fake"
+       _ "knative.dev/pkg/client/injection/ducks/duck/v1/addressable"
        _ "knative.dev/pkg/client/injection/kube/informers/core/v1/configmap/fake"
        _ "knative.dev/pkg/client/injection/kube/informers/core/v1/pod/fake"
        _ "knative.dev/pkg/client/injection/kube/informers/core/v1/secret/fake"
 
+       _ "knative.dev/eventing-kafka-broker/control-plane/pkg/client/internals/kafka/injection/informers/eventing/v1alpha1/consumergroup/fake"
+
        "knative.dev/eventing-kafka-broker/control-plane/pkg/config"
 )

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
control-plane/pkg/reconciler/trigger/v2/controllerv2.go	Do not exist	34.1%
control-plane/pkg/reconciler/trigger/v2/triggerv2.go	Do not exist	0.0%

[knative-prow-robot]

@aavarghese: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-knative-sandbox-eventing-kafka-broker-go-coverage	96fc294	link	false	/test pull-knative-sandbox-eventing-kafka-broker-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[pierDipi]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aavarghese, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment