-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.12] Remove activationLagThreshold to fix 0->1 scaling #3481
[release-1.12] Remove activationLagThreshold to fix 0->1 scaling #3481
Conversation
Signed-off-by: Calum Murray <cmurray@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #3481 +/- ##
==================================================
+ Coverage 58.48% 61.57% +3.09%
- Complexity 0 761 +761
==================================================
Files 91 181 +90
Lines 9319 12396 +3077
Branches 0 265 +265
==================================================
+ Hits 5450 7633 +2183
- Misses 3433 4161 +728
- Partials 436 602 +166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retest-required |
/retest |
/test reconciler-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test reconciler-tests |
/retest-required |
1dbc41d
into
knative-extensions:release-1.12
This is an automated cherry-pick of #3479