Remove activationLagThreshold to fix 0->1 scaling

[Cali0707]

Fixes Kafka source tests when KEDA is enabled (hopefully).

From discussion here, we shouldn't be using activationLagThreshold unless we want to initially scale form 0 to n>1. Hence, our scaling 0 -> 1 was not working.

Proposed Changes

• Remove activationLagThreshold parameter (letting it default to 0)

Release Note

KafkaSource KEDA scaling from 0 -> 1 now works even when only a single event is in the topic

Docs

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[Cali0707]

/test reconciler-tests-keda

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9f6197) 58.46% compared to head (4240d41) 61.52%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3479      +/-   ##
============================================
+ Coverage     58.46%   61.52%   +3.06%     
- Complexity        0      764     +764     
============================================
  Files            91      181      +90     
  Lines          9338    12413    +3075     
  Branches          0      266     +266     
============================================
+ Hits           5459     7637    +2178     
- Misses         3443     4165     +722     
- Partials        436      611     +175     

Flag	Coverage Δ
java-unittests	70.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Cali0707]

/cc @pierDipi

[pierDipi]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Cali0707,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Cali0707]

/retest-required

[Cali0707]

/cherry-pick release-1.12

[knative-prow-robot]

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Cali0707]

/cherry-pick release-1.11

[knative-prow-robot]

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Cali0707]

/test reconciler-tests

[knative-prow-robot]

@Cali0707: new pull request created: #3481

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

@Cali0707: new pull request created: #3482

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.