Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.11] Remove activationLagThreshold to fix 0->1 scaling #3482

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[release-1.11] Remove activationLagThreshold to fix 0->1 scaling #3482

merged 1 commit into from
Dec 1, 2023

Conversation

knative-prow-robot
Copy link
Contributor

@knative-prow-robot knative-prow-robot commented Nov 23, 2023 •
edited by Cali0707
Loading

This is an automated cherry-pick of #3479

KafkaSource KEDA scaling from 0 -> 1 now works even when only a single event is in the topic

@Cali0707 @knative-prow-robot
Remove activationLagThreshold to fix 0->1 scaling
a45be76 
Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow-robot knative-prow-robot mentioned this pull request Nov 23, 2023
Merged
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 23, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67fc0ea) 58.49% compared to head (a45be76) 63.53%.
Report is 2 commits behind head on release-1.11.

Additional details and impacted files 
@@                Coverage Diff                 @@
##             release-1.11    #3482      +/-   ##
==================================================
+ Coverage           58.49%   63.53%   +5.03%     
- Complexity              0      768     +768     
==================================================
  Files                  91      169      +78     
  Lines                9163    11942    +2779     
  Branches                0      247     +247     
==================================================
+ Hits                 5360     7587    +2227     
- Misses               3382     3779     +397     
- Partials              421      576     +155
Flag Coverage Δ
java-unittests 80.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cali0707
Copy link
Member

/retest-required

@creydr
Copy link
Contributor

creydr commented Nov 24, 2023

/retest

matzew
matzew approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@matzew
Copy link
Contributor

matzew commented Nov 30, 2023

/test channel-integration-tests-ssl

@matzew
Copy link
Contributor

matzew commented Nov 30, 2023

/retest

1 similar comment
@matzew
Copy link
Contributor

matzew commented Nov 30, 2023

/retest

@Cali0707
Copy link
Member

/retest-required

@matzew
Copy link
Contributor

matzew commented Dec 1, 2023

/test reconciler-tests

@matzew
Copy link
Contributor

matzew commented Dec 1, 2023

/test reconciler-tests-namespaced-broker

@knative-prow knative-prow bot merged commit 3076046 into knative-extensions:release-1.11 Dec 1, 2023
32 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@odacremolbap odacremolbap Awaiting requested review from odacremolbap

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knative-prow-robot @Cali0707 @creydr @matzew