Allow consolidated channel to use distributed-style secret format

[eric-sap]

Fixes #679

Proposed Changes

• 🐛 The consolidated channel can now use the distributed-channel-style secret format (in addition to the TLS/SASL information that is in the common configmap). The old secret format is also still supported for now.
• 🧽 The consolidated channel now pays attention to the sarama.enableLogging field in the configmap

Release Note

Consolidated channel TLS/SASL secret format has changed.  No action necessary at this time (old format will continue to work).

[codecov]

Codecov Report

Merging #680 (f8489d2) into main (504c3be) will decrease coverage by 0.02%.
The diff coverage is 97.61%.

@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
- Coverage   75.33%   75.30%   -0.03%     
==========================================
  Files         132      132              
  Lines        5782     5775       -7     
==========================================
- Hits         4356     4349       -7     
  Misses       1206     1206              
  Partials      220      220              

Impacted Files	Coverage Δ
...consolidated/reconciler/controller/kafkachannel.go	49.03% <0.00%> (ø)
pkg/channel/consolidated/utils/util.go	100.00% <100.00%> (ø)
pkg/common/config/util.go	100.00% <100.00%> (ø)
pkg/common/kafka/sarama/sarama.go	98.33% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 504c3be...f8489d2. Read the comment docs.

[matzew]

/assign @aliok
Let's be careful about this, so that we do not break existing users

[aliok]

/test pull-knative-sandbox-eventing-kafka-integration-test-channel-consolidated-sasl

[aliok]

LGTM

I can have another look when the failing test got fixed.

Thanks for adding the backwards compatibility. We should remember to deprecate the old format in a few releases.

[eric-sap]

/hold
Would like to leave this at least overnight for comments since it's cross-channel-type again

[travis-minke-sap]

Looks good - couple minor nits... I'll leave it to the consolidated channel experts to merge since it's mostly adjusting their implementation.

[matzew]

/assign @matzew I will take a look at this on Friday (off tomorrow)

On Wed 2. Jun 2021 at 20:20, eric-sap ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pkg/common/config/util.go <#680 (comment)> : > secrets := kubeclient.Get(ctx).CoreV1().Secrets(secretNamespace) secret, err := secrets.Get(ctx, secretName, metav1.GetOptions{}) if err != nil { - return nil, err + // Consolidated channel backwards-compatibility - A nonexistent secret returns a nil config + return nil That's true, especially since it now applies to the distributed channel as well. I don't think there would be any users who rely on a missing secret to cause an error (but I've been wrong about those kinds of things before). I made the comment more purpose-oriented. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#680 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABGPTXZJV2DA6A5U4LOUZTTQZY6JANCNFSM455QUBYQ> .

-- Sent from Gmail Mobile

[matzew]

/test all

[matzew]

@travis-minke-sap @eric-sap we need to change the docs repo with this too .

I am not holding the PR for that. But please let's get some update there

[matzew]

/lgtm
/approve

/test all

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eric-sap, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/common/kafka/sarama/sarama.go	98.7%	98.7%	-0.0

[eric-sap]

/unhold