Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed references to consolidated-channel-specific secrets #3729

Merged
merged 4 commits into from
Jun 7, 2021
Merged

Removed references to consolidated-channel-specific secrets #3729

merged 4 commits into from
Jun 7, 2021

Conversation

eric-sap
Copy link
Contributor

@eric-sap eric-sap commented Jun 4, 2021

As of knative-sandbox PR 680 (knative-extensions/eventing-kafka#680), the consolidated channel no longer uses a distinct secret format.

Proposed Changes

  • Removed references to consolidated-channel-style secrets (ca.crt and related fields) that are now part of the config-kafka configmap (and the same as the distributed channel)

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 4, 2021
@knative-prow-robot
Copy link
Contributor

Hi @eric-sap. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 4, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 4, 2021
@netlify
Copy link

netlify bot commented Jun 4, 2021

✔️ Deploy Preview for dev-knative ready!

🔨 Explore the source changes: 6770f31

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60ba30357483970008044468

😎 Browse the preview: https://deploy-preview-3729--dev-knative.netlify.app/development/eventing/samples/kafka/channel

@eric-sap
Copy link
Contributor Author

eric-sap commented Jun 4, 2021

After all of the modifications to make the consolidated-vs-distributed authentication clear, we decided to merge the secret types anyway. Hopefully this is just a simple removal of a section; the preview looks correct to me.

@abrennan89
Copy link
Contributor

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2021
@abrennan89
Copy link
Contributor

/approve

Can I get someone from @knative/eventing-reviewers to take a look and lgtm this please?

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2021
@csantanapr
Copy link
Member

/assign @matzew
/assign @travis-minke-sap
Could you folks take a look when you have a chance?

@knative-prow-robot
Copy link
Contributor

@csantanapr: GitHub didn't allow me to assign the following users: travis-minke-sap.

Note that only knative members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @matzew
/assign @travis-minke-sap
Could you folks take a look when you have a chance?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travis-minke-sap
Copy link
Contributor

looks good to me - will leave for Matthias to approve/merge.

matzew
matzew approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, eric-sap, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit d190530 into knative:mkdocs Jun 7, 2021
RichardJJG pushed a commit to RichardJJG/docs that referenced this pull request Jun 30, 2021
@eric-sap @RichardJJG
Removed references to consolidated-channel-specific secrets (knative#…
0ca5666 
…3729)

* Updated samples/kafka/channel with configmap information

* Removed references to old-style consolidated channel secret format
RichardJJG pushed a commit to RichardJJG/docs that referenced this pull request Jul 1, 2021
@eric-sap @RichardJJG
Removed references to consolidated-channel-specific secrets (knative#…
ec6c231 
…3729)

* Updated samples/kafka/channel with configmap information

* Removed references to old-style consolidated channel secret format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eric-sap @knative-prow-robot @abrennan89 @csantanapr @travis-minke-sap @matzew