[main] KafkaChannel to init offsets before dispatcher

[aliok]

Manual cherry pick of the same fix in 0.24: #886

Release Note

- 🐛  Fixed a bug that was causing Kafka Channel dispatcher to miss some events in case the offset for the consumer group was not initialized

Docs

[codecov]

Codecov Report

Merging #911 (598969b) into main (9fe562d) will decrease coverage by 0.48%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
- Coverage   76.00%   75.51%   -0.49%     
==========================================
  Files         139      137       -2     
  Lines        6775     6554     -221     
==========================================
- Hits         5149     4949     -200     
+ Misses       1345     1320      -25     
- Partials      281      285       +4     

Impacted Files	Coverage Δ
...l/consolidated/reconciler/controller/controller.go	0.00% <0.00%> (ø)
...g/common/consumer/consumergroup_offsets_checker.go	4.16% <4.16%> (ø)
pkg/channel/consolidated/dispatcher/dispatcher.go	64.13% <33.33%> (+2.54%)	⬆️
...consolidated/reconciler/controller/kafkachannel.go	47.56% <37.03%> (-2.12%)	⬇️
pkg/common/consumer/consumer_factory.go	78.00% <45.45%> (-7.37%)	⬇️
pkg/common/kafka/offset/offsets.go	59.18% <63.63%> (+0.36%)	⬆️
pkg/source/adapter/adapter.go	54.16% <66.66%> (-0.58%)	⬇️
.../distributed/dispatcher/controller/kafkachannel.go	85.12% <100.00%> (+0.25%)	⬆️
...el/distributed/dispatcher/dispatcher/dispatcher.go	96.77% <100.00%> (ø)
pkg/common/consumer/consumer_handler.go	54.83% <100.00%> (ø)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe562d...598969b. Read the comment docs.

[matzew]

/hold

let's use 🍒-pick of the "merge sha" ...

[aliok]

let's use 🍒-pick of the "merge sha" ...

If it works yes, that's nicer.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[pierDipi]

@googlebot I consent.

[aliok]

Let's see this one passes the tests then I will cherry pick the changes and do the dance from 0.24 -> ... -> main

[pierDipi]

/test pull-knative-sandbox-eventing-kafka-upgrade-tests

[aliok]

I rebased this on top of main head now

[pierDipi]

This is green again ...

[aliok]

Ok, let's see what happens to the 0.26 backport: #928

[aliok]

/hold

Some renaming to be done here on this PR

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/channel/consolidated/dispatcher/dispatcher.go	64.5%	66.1%	1.6
pkg/channel/consolidated/reconciler/controller/kafkachannel.go	54.8%	54.3%	-0.5
pkg/channel/distributed/dispatcher/controller/kafkachannel.go	87.5%	87.6%	0.1
pkg/common/consumer/consumer_factory.go	87.2%	81.2%	-5.9
pkg/common/consumer/consumer_manager.go	96.9%	96.9%	0.0
pkg/common/consumer/consumergroup_offsets_checker.go	Do not exist	4.3%
pkg/common/kafka/offset/offsets.go	81.1%	81.5%	0.4

[knative-prow-robot]

@aliok: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-knative-sandbox-eventing-kafka-go-coverage	598969b	link	false	/test pull-knative-sandbox-eventing-kafka-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[aliok]

/test pull-knative-sandbox-eventing-kafka-integration-test-channel-distributed

Unable to connect to the server: net/http: TLS handshake timeout

[matzew]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aliok,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aliok]

/unhold