-
Notifications
You must be signed in to change notification settings - Fork 82
[0.26] KafkaChannel to init offsets before dispatcher #928
[0.26] KafkaChannel to init offsets before dispatcher #928
Conversation
Codecov Report
@@ Coverage Diff @@
## release-0.26 #928 +/- ##
===============================================
Coverage ? 74.09%
===============================================
Files ? 152
Lines ? 6953
Branches ? 0
===============================================
Hits ? 5152
Misses ? 1508
Partials ? 293 Continue to review full report at Codecov.
|
All green - once again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
/lgtm
All green - once again |
Again: All green... Here we go again |
The following is the coverage report on the affected files.
|
some infra.... |
@aliok: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-knative-sandbox-eventing-kafka-integration-test-channel-distributed Infra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
* Move initOffsets functionality to a common package (knative-extensions#887) Co-authored-by: Ali Ok <aliok@redhat.com> * Fix Kafka channel event loss during subscription becoming ready (knative-extensions#928) Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Fixes #
Proposed Changes
Release Note
Docs