Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

[0.26] KafkaChannel to init offsets before dispatcher #928

Conversation

aliok
Copy link
Member

@aliok aliok commented Oct 8, 2021

Fixes #

Proposed Changes

Release Note


Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 8, 2021
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 8, 2021
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-0.26@a001ba2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             release-0.26     #928   +/-   ##
===============================================
  Coverage                ?   74.09%           
===============================================
  Files                   ?      152           
  Lines                   ?     6953           
  Branches                ?        0           
===============================================
  Hits                    ?     5152           
  Misses                  ?     1508           
  Partials                ?      293           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a001ba2...8a601d2. Read the comment docs.

@matzew
Copy link
Contributor

matzew commented Oct 8, 2021

All green - once again
/test all

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
/lgtm

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2021
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2021
@matzew
Copy link
Contributor

matzew commented Oct 8, 2021

All green - once again
/test all

@matzew
Copy link
Contributor

matzew commented Oct 9, 2021

Again: All green... Here we go again
/test all

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/channel/consolidated/dispatcher/dispatcher.go 64.5% 66.1% 1.6
pkg/channel/consolidated/reconciler/controller/kafkachannel.go 54.8% 54.3% -0.5
pkg/channel/distributed/dispatcher/controller/kafkachannel.go 87.5% 87.6% 0.1
pkg/common/consumer/consumer_factory.go 87.2% 81.2% -5.9
pkg/common/consumer/consumer_manager.go 96.9% 96.9% 0.0
pkg/common/consumer/consumergroup_offsets_checker.go Do not exist 4.3%
pkg/common/kafka/offset/offsets.go 81.1% 81.5% 0.4

@matzew
Copy link
Contributor

matzew commented Oct 9, 2021

error: failed to create clusterrolebinding: Post "https://34.75.158.137/apis/rbac.authorization.k8s.io/v1/clusterrolebindings?fieldManager=kubectl-create": net/http: TLS handshake timeout

some infra....

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Oct 9, 2021

@aliok: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-knative-sandbox-eventing-kafka-go-coverage 8a601d2 link false /test pull-knative-sandbox-eventing-kafka-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aliok
Copy link
Member Author

aliok commented Oct 11, 2021

/test pull-knative-sandbox-eventing-kafka-integration-test-channel-distributed

Infra

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Contributor

matzew commented Oct 11, 2021

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2021
@knative-prow-robot knative-prow-robot merged commit dcdd9d1 into knative-extensions:release-0.26 Oct 11, 2021
@aliok aliok deleted the kafka-ch-event-loss-026-backport-main branch October 11, 2021 07:12
aliok added a commit to aliok/eventing-kafka that referenced this pull request Oct 11, 2021
openshift-merge-robot pushed a commit to openshift-knative/eventing-kafka that referenced this pull request Oct 11, 2021
* Move initOffsets functionality to a common package (knative-extensions#887)

Co-authored-by: Ali Ok <aliok@redhat.com>

* Fix Kafka channel event loss during subscription becoming ready (knative-extensions#928)

Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants