implemented update subscription #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
do-not-merge/work-in-progress
knative-prow
bot
added
the
size/S
Codecov Report
@@ Coverage Diff @@
## release-1.10 #427 +/- ##
================================================
+ Coverage 39.15% 45.57% +6.42%
================================================
Files 29 29
Lines 1931 1953 +22
================================================
+ Hits 756 890 +134
+ Misses 1129 1008 -121
- Partials 46 55 +9
|
knative-prow
bot
added
size/M
knative-prow
bot
removed
the
do-not-merge/work-in-progress
|
cc @dan-j |
|
/assign @pierDipi |
knative-prow
bot
added
the
do-not-merge/work-in-progress
knative-prow
bot
added
size/L
knative-prow
bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astelmashenko, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/cherrypick main |
|
@astelmashenko: new pull request created: #429 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
astelmashenko
added a commit
to astelmashenko/eventing-natss
that referenced
this pull request
Oct 9, 2023
* implemented update subscription * do not call addstream if it is existing, to prevent error propagation * added comments * added reconciler test * added reconciler tests * removed unused types * added check for err
astelmashenko
added a commit
to astelmashenko/eventing-natss
that referenced
this pull request
Oct 9, 2023
* implemented update subscription * do not call addstream if it is existing, to prevent error propagation * added comments * added reconciler test * added reconciler tests * removed unused types * added check for err
knative-prow bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
* removed timer which marked messages as InProgress * goimports * implemented update subscription (#427) * implemented update subscription * do not call addstream if it is existing, to prevent error propagation * added comments * added reconciler test * added reconciler tests * removed unused types * added check for err * implemented retries based on JetStream; consumer ackWait and maxDeliver are not come from Subscription * removed timer which marked messages as InProgress * goimports * implemented retries based on JetStream; consumer ackWait and maxDeliver are not come from Subscription * changed nil to noRetries * removed timer which marked messages as InProgress * goimports * implemented update subscription (#427) * implemented update subscription * do not call addstream if it is existing, to prevent error propagation * added comments * added reconciler test * added reconciler tests * removed unused types * added check for err * implemented retries based on JetStream; consumer ackWait and maxDeliver are not come from Subscription * changed nil to noRetries * updated nats client lib, fixed backoff logic * update codeget and removed commented code * implemented exponential backoff right way on JetStream side * removed timer which marked messages as InProgress * goimports * implemented retries based on JetStream; consumer ackWait and maxDeliver are not come from Subscription * updated nats client lib, fixed backoff logic * update codeget and removed commented code * implemented exponential backoff right way on JetStream side * removed timer which marked messages as InProgress * goimports * implemented retries based on JetStream; consumer ackWait and maxDeliver are not come from Subscription * updated nats client lib, fixed backoff logic * update codeget and removed commented code * implemented exponential backoff right way on JetStream side * rebased * go mod tidy/vendor * updatecodegen * added calcuation of request deadline * removed logging err back * updated tests to cover missing lines * using retryconfig.timeout as fallback, when there is no consumerTemplate.ackWait * fix possible nil pointer error * re-implemented message_dispatcher for jetstream side retries * go-imports message_dispatcher.go * tests: message_dispatcher.go * goimports: message_dispatcher.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Updates subscription configuration on dispatcher: retryConfig, url, reply, deadLetter
Release Note