Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] implemented update subscription #429

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #427

Fixes updating of existing subscriptions on dispatcher: retryConfig, url, reply, deadLetter

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 13, 2023
@knative-prow knative-prow bot requested review from creydr and matzew September 13, 2023 10:41
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #429 (c2c440e) into main (0c051c9) will increase coverage by 6.46%.
Report is 5 commits behind head on main.
The diff coverage is 67.74%.

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   38.97%   45.44%   +6.46%     
==========================================
  Files          29       29              
  Lines        1919     1941      +22     
==========================================
+ Hits          748      882     +134     
+ Misses       1125     1004     -121     
- Partials       46       55       +9     
Files Coverage Δ
pkg/channel/jetstream/dispatcher/dispatcher.go 50.61% <81.81%> (+25.50%) ⬆️
pkg/channel/jetstream/dispatcher/reconciler.go 57.29% <33.33%> (+29.18%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023
@knative-prow knative-prow bot merged commit 10aeb92 into knative-extensions:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants