Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aligned flags and secrets for system-internal-tls #1116

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Sep 19, 2023

Changes

/kind cleanup

Partially knative/serving#14369
Partially knative/serving#14392
Partially knative/serving#14368

Release Note

net-kourier now uses the new `system-internal-tls` flag to configure encryption of Knative system components.

Docs
Will be done separately when encryption is working end-to-end

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 19, 2023
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1116 (c328c40) into main (3fdb548) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1116      +/-   ##
==========================================
+ Coverage   80.69%   80.81%   +0.12%     
==========================================
  Files          18       18              
  Lines        1383     1392       +9     
==========================================
+ Hits         1116     1125       +9     
  Misses        213      213              
  Partials       54       54              
Files Coverage Δ
pkg/generator/ingress_translator.go 87.26% <100.00%> (+0.37%) ⬆️
pkg/reconciler/ingress/config/store.go 91.66% <100.00%> (ø)

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2023
@ReToCode ReToCode changed the title [WIP] Use aligned flags and secrets for knative-internal-tls [WIP] Use aligned flags and secrets for system-internal-tls Sep 22, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2023
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 3, 2023
@ReToCode ReToCode changed the title [WIP] Use aligned flags and secrets for system-internal-tls Use aligned flags and secrets for system-internal-tls Oct 3, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2023
@ReToCode
Copy link
Member Author

ReToCode commented Oct 3, 2023

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2023
@nak3
Copy link
Contributor

nak3 commented Oct 3, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@nak3
Copy link
Contributor

nak3 commented Oct 3, 2023

/hold

Ah, Code Style / style / Golang / Lint should be fixed.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2023
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2023
@ReToCode
Copy link
Member Author

ReToCode commented Oct 3, 2023

We also need to create the new certificates with SANs in the script.
For now we do not use all of them, but I think it is better to have the correct secrets with SANs that we are going to use in Serving, so we can build on top of that when adding the cluster-local-domain-tls stuff.

@ReToCode
Copy link
Member Author

ReToCode commented Oct 3, 2023

/unhold
@nak3

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2023
@nak3
Copy link
Contributor

nak3 commented Oct 3, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@knative-prow knative-prow bot merged commit a895a08 into knative-extensions:main Oct 3, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants