Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align flag naming according to the discussion #14368

Closed
3 tasks done
ReToCode opened this issue Sep 14, 2023 · 0 comments · Fixed by knative/networking#858
Closed
3 tasks done

Align flag naming according to the discussion #14368

ReToCode opened this issue Sep 14, 2023 · 0 comments · Fixed by knative/networking#858
Assignees
Labels
triage/accepted Issues which should be fixed (post-triage)
Milestone

Comments

@ReToCode
Copy link
Member

ReToCode commented Sep 14, 2023

Context

According to the discussion in https://docs.google.com/document/d/1b-aCADlUBo2FZEDp5z5XoXlfUT6CvED339fcAdKY66o and https://docs.google.com/document/d/1rpag5-zffHGxAT7V4Nv28C_xx5Ow6L4mZuHbe3ebOQ8, we agreed that we want to align the flags related to Serving Encryption.

Desired target state

We would like to have three flags to configure everything related to Serving Encryption:

  • external-domain-tls: true, false (bool)
  • cluster-local-domain-tls: "disabled", "enabled" (enum) - with options to add mutual, identity later
  • system-internal-tls: "disabled", "enabled" (enum) - with options to add mutual, identity later

Please note, the existing flags need to still work with the following mapping:

  • autoTLS = external-domain-tls
  • system-internal-tls= internal-encryption

Work

@ReToCode ReToCode converted this from a draft issue Sep 14, 2023
@ReToCode ReToCode changed the title Align flag naming according to the discussion Serving Encryption: Align flag naming according to the discussion Sep 14, 2023
@ReToCode ReToCode changed the title Serving Encryption: Align flag naming according to the discussion Align flag naming according to the discussion Sep 14, 2023
@ReToCode ReToCode added the triage/accepted Issues which should be fixed (post-triage) label Sep 14, 2023
@ReToCode ReToCode self-assigned this Sep 14, 2023
@ReToCode ReToCode moved this to In Progress in Serving Encryption Sep 14, 2023
@ReToCode ReToCode added this to the v1.12.0 milestone Sep 14, 2023
@ReToCode ReToCode moved this to In Progress in Serving Milestones Sep 22, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Serving Milestones Oct 2, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Serving Encryption Oct 2, 2023
@ReToCode ReToCode reopened this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Issues which should be fixed (post-triage)
Projects
Development

Successfully merging a pull request may close this issue.

1 participant