-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update certificates and SANs used in Serving #14472
Conversation
bumping knative.dev/net-kourier 644b5c8...a895a08: > a895a08 Use aligned flags and secrets for `system-internal-tls` (# 1116) > 3fdb548 upgrade to latest dependencies (# 1127) Signed-off-by: Knative Automation <automation@knative.team>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #14472 +/- ##
==========================================
- Coverage 86.08% 86.06% -0.03%
==========================================
Files 196 196
Lines 14880 14880
==========================================
- Hits 12810 12807 -3
- Misses 1759 1761 +2
- Partials 311 312 +1
☔ View full report in Codecov by Sentry. |
bumping knative.dev/networking c1cae21...97dab15: > 97dab15 upgrade to latest dependencies (# 870) > 463dc38 Cleanup SAN constants and Secrets Keys for system-internal-tls certificates (# 861) > 05d0964 Align the encryption flags (# 858) bumping knative.dev/caching da42414...808ee92: > 808ee92 upgrade to latest dependencies (# 791) bumping knative.dev/pkg 1860700...294e777: > 294e777 Add rest.Config to fake context in SetupFakeContext (# 2847) > 0736c74 Add SinkAudience to SourceStatus (# 2844) Signed-off-by: Knative Automation <automation@knative.team>
@dprotaso any idea what that could be? Checksums in
|
It seems that it was caused by this override https://github.com/knative/serving/blob/main/test/config/ytt/core/overlay-cluster-local-override.yaml It replaces all of |
Aww, makes sense. Nice find @nak3! Here a PR to fix this: knative/networking#872. |
/test upgrade-tests |
looks good to me, but I can hold for others /lgtm |
Do we need to have release notes, do we break anything wrt flags supported etc? |
/approve @ReToCode Just one comment above. Seems most work is refactoring for experimental flags. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Sorry I missed Stavros's comment but Release Notes can be updated after the merge. |
I added them above. I hope they are still picked up? |
Yes, the release note should be picked up when new release is created (more precisely, that is done when we generated the release note by github action). |
Proposed Changes
Release Note
Docs
PRs for docs will follow separately in #14368