Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update certificates and SANs used in Serving #14472

Merged
merged 8 commits into from
Oct 5, 2023

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Oct 3, 2023

Proposed Changes

Release Note

Renames the flags that control encryption
- `auto-tls` is now named `external-domain-tls`
- `internal-encryption` is now named `system-internal-tls`
- `cluster-local-domain-tls` is introduced as a new alpha state flag to control TLS certificates for cluster-local domains

Docs
PRs for docs will follow separately in #14368

KauzClay and others added 6 commits October 3, 2023 14:55
bumping knative.dev/net-kourier 644b5c8...a895a08:
  > a895a08 Use aligned flags and secrets for `system-internal-tls` (# 1116)
  > 3fdb548 upgrade to latest dependencies (# 1127)

Signed-off-by: Knative Automation <automation@knative.team>
@knative-prow knative-prow bot added the area/API API objects and controllers label Oct 3, 2023
@knative-prow knative-prow bot added area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (4c3aaee) 86.08% compared to head (90aa5b3) 86.06%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14472      +/-   ##
==========================================
- Coverage   86.08%   86.06%   -0.03%     
==========================================
  Files         196      196              
  Lines       14880    14880              
==========================================
- Hits        12810    12807       -3     
- Misses       1759     1761       +2     
- Partials      311      312       +1     
Files Coverage Δ
pkg/reconciler/autoscaling/kpa/kpa.go 95.26% <100.00%> (ø)
pkg/reconciler/route/resources/ingress.go 94.80% <100.00%> (ø)
pkg/reconciler/revision/reconcile_resources.go 67.33% <0.00%> (ø)
pkg/reconciler/revision/resources/deploy.go 90.13% <0.00%> (ø)
pkg/reconciler/revision/revision.go 92.13% <0.00%> (ø)
cmd/activator/main.go 0.00% <0.00%> (ø)
pkg/activator/certificate/cache.go 41.81% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bumping knative.dev/networking c1cae21...97dab15:
  > 97dab15 upgrade to latest dependencies (# 870)
  > 463dc38 Cleanup SAN constants and Secrets Keys for system-internal-tls certificates (# 861)
  > 05d0964 Align the encryption flags (# 858)
bumping knative.dev/caching da42414...808ee92:
  > 808ee92 upgrade to latest dependencies (# 791)
bumping knative.dev/pkg 1860700...294e777:
  > 294e777 Add rest.Config to fake context in SetupFakeContext (# 2847)
  > 0736c74 Add SinkAudience to SourceStatus (# 2844)

Signed-off-by: Knative Automation <automation@knative.team>
@ReToCode
Copy link
Member Author

ReToCode commented Oct 3, 2023

@dprotaso any idea what that could be? Checksums in config-networking seem fine and the code clearly does not patch the _example stuff:

  • kubectl patch cm config-network -n 0af4ed85-a6ca-4c44-b88c-f692d760a858 -p '{"data":{"system-internal-tls":"Enabled"}}'
    Error from server (BadRequest): admission webhook "config.webhook.serving.knative.dev" denied the request: validation failed: the update modifies a key in "_example" which is probably not what you want. Instead, copy the respective setting to the top-level of the ConfigMap, directly below "data"
    Setting feature system-internal-tls to Enabled

@nak3
Copy link
Contributor

nak3 commented Oct 4, 2023

any idea what that could be? Checksums in config-networking seem fine and the code clearly does not patch the _example stuff:

It seems that it was caused by this override https://github.com/knative/serving/blob/main/test/config/ytt/core/overlay-cluster-local-override.yaml

It replaces all of cluster.local with a custom domain (like c6401203910.local). So the following comment line is replaced and the checksums makes mismatch.

https://github.com/knative/networking/blob/97dab159e1855d6165151ca66c16f69f7091d375/config/config-network.yaml#L129

@ReToCode
Copy link
Member Author

ReToCode commented Oct 4, 2023

Aww, makes sense. Nice find @nak3! Here a PR to fix this: knative/networking#872.

@ReToCode
Copy link
Member Author

ReToCode commented Oct 4, 2023

/test upgrade-tests

@ReToCode
Copy link
Member Author

ReToCode commented Oct 4, 2023

🎉

/assign @nak3
/assign @KauzClay
/assign @dprotaso

@KauzClay
Copy link
Contributor

KauzClay commented Oct 4, 2023

looks good to me, but I can hold for others

/lgtm
/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023
@skonto
Copy link
Contributor

skonto commented Oct 4, 2023

Do we need to have release notes, do we break anything wrt flags supported etc?

@skonto
Copy link
Contributor

skonto commented Oct 4, 2023

/approve

@ReToCode Just one comment above. Seems most work is refactoring for experimental flags.

@knative-prow
Copy link

knative-prow bot commented Oct 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2023
@nak3
Copy link
Contributor

nak3 commented Oct 5, 2023

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2023
@knative-prow knative-prow bot merged commit 3cafe59 into knative:main Oct 5, 2023
63 checks passed
@nak3
Copy link
Contributor

nak3 commented Oct 5, 2023

Sorry I missed Stavros's comment but Release Notes can be updated after the merge.

@ReToCode
Copy link
Member Author

ReToCode commented Oct 5, 2023

I added them above. I hope they are still picked up?

@nak3
Copy link
Contributor

nak3 commented Oct 5, 2023

Yes, the release note should be picked up when new release is created (more precisely, that is done when we generated the release note by github action).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants