-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glue the new DeliverySpec.Timeout #1034
Glue the new DeliverySpec.Timeout #1034
Conversation
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a reconciler test with this timeout?
/approve
I'm gonna add one upstream and then set it up here |
I meant a test for |
Codecov Report
@@ Coverage Diff @@
## main #1034 +/- ##
============================================
+ Coverage 75.10% 75.22% +0.11%
- Complexity 420 427 +7
============================================
Files 75 77 +2
Lines 2928 2938 +10
Branches 128 128
============================================
+ Hits 2199 2210 +11
+ Misses 570 569 -1
Partials 159 159
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Fixes #757, followup of #1021, part of knative/eventing#5148
Proposed Changes
DeliverySpec.Timeout
fieldRelease Note