Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update k8s deps which include leader election fixes #449

Merged
merged 1 commit into from
Dec 2, 2020
Merged

update k8s deps which include leader election fixes #449

merged 1 commit into from
Dec 2, 2020

Conversation

arghya88
Copy link
Contributor

@arghya88 arghya88 commented Dec 2, 2020

Signed-off-by: Arghya Sadhu arghya88@gmail.com

Fixes #446

Proposed Changes

🐛 Leader election transition improvements

Release Note

Leader election transition improvements

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 2, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020 •
edited
Loading

Codecov Report

Merging #449 (c81c05f) into master (50e92f9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #449   +/-   ##
=========================================
  Coverage     77.14%   77.14%           
  Complexity      260      260           
=========================================
  Files            58       58           
  Lines          1873     1873           
  Branches         82       82           
=========================================
  Hits           1445     1445           
  Misses          320      320           
  Partials        108      108
Flag Coverage Δ Complexity Δ
java-unittests 77.13% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50e92f9...c81c05f. Read the comment docs.

@arghya88
Copy link
Contributor Author

arghya88 commented Dec 2, 2020

/cc @pierDipi

pierDipi
pierDipi reviewed Dec 2, 2020
View reviewed changes
hack/update-deps.sh Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@pierDipi pierDipi mentioned this pull request Dec 2, 2020
Merged
@pierDipi
Copy link
Member

pierDipi commented Dec 2, 2020

/kind bug

@knative-prow-robot knative-prow-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 2, 2020
@arghya88
update k8s deps which include leader election fixes
c81c05f 
Signed-off-by: Arghya Sadhu <arghya88@gmail.com>
@arghya88 arghya88 force-pushed the leader-election-improvements branch from ec7c7ff to c81c05f Compare December 2, 2020 09:55
@arghya88
Copy link
Contributor Author

arghya88 commented Dec 2, 2020

@pierDipi done the changes.PTAL

pierDipi
pierDipi approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @arghya88!

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arghya88, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@knative-prow-robot knative-prow-robot merged commit 2ff24d9 into knative-extensions:master Dec 2, 2020
@arghya88 arghya88 deleted the leader-election-improvements branch December 2, 2020 10:55
@pierDipi pierDipi mentioned this pull request Dec 9, 2020
Closed
pierDipi pushed a commit to pierDipi/eventing-kafka-broker that referenced this pull request Feb 27, 2021
@arghya88 @pierDipi
update k8s deps which include leader election fixes (knative-extensio…
56d11ac 
…ns#449)

Signed-off-by: Arghya Sadhu <arghya88@gmail.com>
mgencur pushed a commit to mgencur/eventing-kafka-broker that referenced this pull request Nov 9, 2022
@pierDipi
[release-v1.6] Fix CI (knative-extensions#449)
787a431 
* Run CI

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Apply openshift/patches and re-generate release

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Resolve images using tags instead of image streams

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Generate release

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@Harwayne Harwayne Awaiting requested review from Harwayne

@matzew matzew Awaiting requested review from matzew

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump k8s to v0.18.12 to get leader election release bug fixes
3 participants
@arghya88 @pierDipi @knative-prow-robot