Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out of bounds in unordered offset manager #814

Merged

Conversation

slinkydeveloper
Copy link
Contributor

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Fix #813

Proposed Changes

  • 🐛 Fix out of bounds in unordered offset manager

Release Note

:bug: Fix out of bounds in unordered offset manager

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper requested review from a team as code owners April 16, 2021 12:57
@slinkydeveloper slinkydeveloper requested review from tcnghia and a user April 16, 2021 12:57
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 16, 2021
@knative-prow-robot knative-prow-robot added area/data-plane size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2021
@slinkydeveloper
Copy link
Contributor Author

/cherry-pick release-0.22

@knative-prow-robot
Copy link
Contributor

@slinkydeveloper: once the present PR merges, I will cherry-pick it on top of release-0.22 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #814 (84baddd) into main (4c7f76d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #814   +/-   ##
=========================================
  Coverage     76.53%   76.53%           
  Complexity      439      439           
=========================================
  Files            77       77           
  Lines          2924     2924           
  Branches        133      133           
=========================================
  Hits           2238     2238           
  Misses          535      535           
  Partials        151      151           
Flag Coverage Δ Complexity Δ
java-unittests 80.20% <100.00%> (ø) 439.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...spatcher/consumer/impl/UnorderedOffsetManager.java 100.00% <100.00%> (ø) 13.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c7f76d...84baddd. Read the comment docs.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2021
@knative-prow-robot knative-prow-robot merged commit e1a3c19 into knative-extensions:main Apr 18, 2021
@knative-prow-robot
Copy link
Contributor

@slinkydeveloper: new pull request created: #816

In response to this:

/cherry-pick release-0.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dispatcher logs ArrayIndexOutOfBoundsExceptions
3 participants