Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Upgrade KafkaCat image used in KafkaSource e2e tests #790

Merged

Conversation

devguyio
Copy link
Contributor

@devguyio devguyio commented Aug 5, 2021

The 1.6.0 version includes built-in retrying.

Fixes #789

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 5, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2021
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #790 (9a727b4) into main (ca4d18a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #790   +/-   ##
=======================================
  Coverage   75.41%   75.41%           
=======================================
  Files         144      144           
  Lines        6497     6497           
=======================================
  Hits         4900     4900           
  Misses       1376     1376           
  Partials      221      221           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca4d18a...9a727b4. Read the comment docs.

@lionelvillard
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2021
@knative-prow-robot knative-prow-robot merged commit 75de46e into knative-extensions:main Aug 5, 2021
@devguyio
Copy link
Contributor Author

devguyio commented Aug 5, 2021

/cherry-pick release-0.23

@knative-prow-robot
Copy link
Contributor

@devguyio: new pull request created: #792

In response to this:

/cherry-pick release-0.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@devguyio
Copy link
Contributor Author

devguyio commented Aug 5, 2021

/cherry-pick release-0.24

@knative-prow-robot
Copy link
Contributor

@devguyio: new pull request created: #793

In response to this:

/cherry-pick release-0.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

devguyio added a commit to devguyio/eventing-kafka that referenced this pull request Aug 5, 2021
devguyio added a commit to devguyio/eventing-kafka that referenced this pull request Aug 5, 2021
openshift-ci bot pushed a commit to openshift-knative/eventing-kafka that referenced this pull request Aug 5, 2021
openshift-ci bot pushed a commit to openshift-knative/eventing-kafka that referenced this pull request Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KafkaSource] E2e tests should retry producing events in the kafkacat producer-container
3 participants