feat: function creation timestamp#651
Merged
knative-prow-robot merged 1 commit intoknative:mainfrom Nov 11, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 36.26% 36.31% +0.04%
==========================================
Files 38 38
Lines 3847 3850 +3
==========================================
+ Hits 1395 1398 +3
Misses 2268 2268
Partials 184 184
Continue to review full report at Codecov.
|
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jrangelramos
pushed a commit
to jrangelramos/func
that referenced
this pull request
Aug 24, 2023
Signed-off-by: Matej Vasek <mvasek@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
It is becoming clear that a timestamp of when a Function successfully completed the creation process will be valuable. In particular this will help with a few forthcoming PRs currently WIP, I'm separating this into its own PR to solicit feedback such as consequences unanticipated.