Skip to content

feat: function creation timestamp#651

Merged
knative-prow-robot merged 1 commit intoknative:mainfrom
lkingland:lkingland/create-stamp
Nov 11, 2021
Merged

feat: function creation timestamp#651
knative-prow-robot merged 1 commit intoknative:mainfrom
lkingland:lkingland/create-stamp

Conversation

@lkingland
Copy link
Member

Changes

  • 🎁 function creation timestamp

It is becoming clear that a timestamp of when a Function successfully completed the creation process will be valuable. In particular this will help with a few forthcoming PRs currently WIP, I'm separating this into its own PR to solicit feedback such as consequences unanticipated.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 11, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #651 (1ed925b) into main (fc1e874) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
+ Coverage   36.26%   36.31%   +0.04%     
==========================================
  Files          38       38              
  Lines        3847     3850       +3     
==========================================
+ Hits         1395     1398       +3     
  Misses       2268     2268              
  Partials      184      184              
Impacted Files Coverage Δ
function.go 57.57% <ø> (ø)
client.go 60.53% <100.00%> (+0.17%) ⬆️
config.go 62.13% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc1e874...1ed925b. Read the comment docs.

@lance
Copy link
Contributor

lance commented Nov 11, 2021

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 1bf17ec into knative:main Nov 11, 2021
@lkingland lkingland deleted the lkingland/create-stamp branch September 20, 2022 01:02
jrangelramos pushed a commit to jrangelramos/func that referenced this pull request Aug 24, 2023
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants