This repository has been archived by the owner on Sep 5, 2019. It is now read-only.
Update test infrastructure for the 0.1 build release #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create the ~/.ssh dir if it doesn't exist, don't assume it always exist. Backported from knative/test-infra#151.
adrcunha
requested review from
imjasonh
and removed request for
bobcatfish and
srinivashegde86
Backported from #253.
adrcunha
force-pushed
the
update-release-0.1
branch
from
b3b431f to
4a7d85e
Compare
Backported from #271.
adrcunha
force-pushed
the
update-release-0.1
branch
from
4a7d85e to
791a91d
Compare
Instead of relying on default options, use basic authentication for test cluster. Also make `acquire_cluster_admin_role()` handle auth through certificates, since it's used also on deployment. Backport of knative/test-infra#115.
|
/retest |
Because the old private key was in the public repo, GitHub would periodically disable the key, breaking integration tests, and org owners would get spammed with security alerts whenever the repo was forked. This is a new deploy key with read-only access to the repo, and since the private key matter is only included base64'ed in `0-secret.yaml`, GitHub should not alert on it. Backported from #298.
|
This is ready for review now. |
|
/lgtm Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
imjasonh
approved these changes
Oct 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that all tests are running against the current live Prow infrastructure.
Part of knative/test-infra#180.