Fix authentication for test clusters #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
Instead of relying on default options, use basic authentication for test cluster. Also make `acquire_cluster_admin_role()` handle auth through certificates, since it's used also on deployment.
jessiezcc
reviewed
Sep 13, 2018
| kubectl config set-credentials cluster-admin \ | ||
| --username=admin --password=${password} | ||
| else | ||
| local cert=$(mktemp) |
There was a problem hiding this comment.
mktemp is a standard UNIX tool.
|
/lgtm |
adrcunha
added a commit
to knative/serving
that referenced
this pull request
Oct 10, 2018
Instead of relying on default options, use basic authentication for test cluster. Also make acquire_cluster_admin_role() handle auth through certificates, since it's used also on deployment. Backport of knative/test-infra#115
adrcunha
added a commit
to knative/serving
that referenced
this pull request
Oct 10, 2018
Instead of relying on default options, use basic authentication for test cluster. Also make acquire_cluster_admin_role() handle auth through certificates, since it's used also on deployment. Backport of knative/test-infra#115
knative-prow-robot
pushed a commit
to knative/serving
that referenced
this pull request
Oct 11, 2018
…2208) * Fix SSH keys workaround for kubetest Create the ~/.ssh dir if it doesn't exist, don't assume it always exist. Backported from knative/test-infra#151 * Fix authentication for test clusters Instead of relying on default options, use basic authentication for test cluster. Also make acquire_cluster_admin_role() handle auth through certificates, since it's used also on deployment. Backport of knative/test-infra#115 * Increase E2E tests timeout to 20 minutes Currently 10 minutes may not be enough, for example as in #1701. Backport of #1702. * Drop Dockerfile in test images * removed dockerfiles * moved test images to the same location * adjust repo * fix command and docs * update upload-test-images.sh * preserve import paths * fix appYaml path * preserve path in upload-test-images.sh Backport of #1792.
adrcunha
added a commit
to knative/build
that referenced
this pull request
Oct 11, 2018
Instead of relying on default options, use basic authentication for test cluster. Also make `acquire_cluster_admin_role()` handle auth through certificates, since it's used also on deployment. Backport of knative/test-infra#115.
knative-prow-robot
pushed a commit
to knative/build
that referenced
this pull request
Oct 11, 2018
* Fix SSH keys workaround for kubetest Create the ~/.ssh dir if it doesn't exist, don't assume it always exist. Backported from knative/test-infra#151. * Rename //tests to //test to keep naming uniform across the repos Backported from #253. * Use the latest GKE for integration tests Backported from #271. * Fix authentication for test clusters Instead of relying on default options, use basic authentication for test cluster. Also make `acquire_cluster_admin_role()` handle auth through certificates, since it's used also on deployment. Backport of knative/test-infra#115. * Use new valid deploy key, delete old key Because the old private key was in the public repo, GitHub would periodically disable the key, breaking integration tests, and org owners would get spammed with security alerts whenever the repo was forked. This is a new deploy key with read-only access to the repo, and since the private key matter is only included base64'ed in `0-secret.yaml`, GitHub should not alert on it. Backported from #298.
Cynocracy
pushed a commit
to Cynocracy/test-infra
that referenced
this pull request
Jun 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on default options, use basic authentication for test cluster.
Also make
acquire_cluster_admin_role()handle auth through certificates, since it's used also on deployment.Part of knative/build#286