Document which PodSpec fields are valid

[duglin]

Describe the change you'd like to see
While the yaml for a KnService leverages the Kubernetes PodSpec definition, not all of the PodSpec fields are valid for KnServices. We should document which fields people can use.

[duglin]

Perhaps just a pointer to https://github.com/knative/docs/blob/master/docs/serving/spec/knative-api-specification-1.0.md#container since I didn't see how to get to this doc from our md files.
Seem like https://knative.dev/docs/reference/serving-api/#serving.knative.dev/v1beta1.Revision might be a duplicate, which is unfortunate since that might mean they get out of sync.

[arghya88]

is initcontainers allowed?

[duglin]

@arghya88 no I do not think they are supported yet

[knative-housekeeping-robot]

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale

[knative-housekeeping-robot]

Stale issues rot after 30 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.
Rotten issues close after an additional 30 days of inactivity.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle rotten

[knative-housekeeping-robot]

Rotten issues close after 30 days of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/close

[knative-prow-robot]

@knative-housekeeping-robot: Closing this issue.

In response to this:

Rotten issues close after 30 days of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[duglin]

/reopen

[knative-prow-robot]

@duglin: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-housekeeping-robot]

Rotten issues close after 30 days of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/close

[knative-prow-robot]

@knative-housekeeping-robot: Closing this issue.

In response to this:

Rotten issues close after 30 days of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[duglin]

/reopen

[knative-prow-robot]

@duglin: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[duglin]

/remove-lifecycle rotten

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen.Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[duglin]

/remove-lifecycle stale

[evankanderson]

This is currently only available in code, AFAIK.

The code is here (ValidatePodSpec), but I don't think there's an easy way to go from that code to any sort of documentation. If this is still a high priority, it will probably require some amount of pairing, plus some type of tracking checking for items getting out of date between code and docs. (Possibly as simple as a list of PRs from some date to now affecting the file which could be used to update the documentation.)

/triage needs-eng-input

(We should pair-assign this to an engineer for pairing if it becomes high enough priority that someone wants to start writing this and the code isn't clear on its own.)

[evankanderson]

/remove-triage needs-eng-input

[duglin]

Not sure about its relative priority but as it stands today, only reading the docs I'm not sure someone can figure out which podSpec fields are supported - and I think that's an important concern.

[markusthoemmes]

For whatever that's worth: We now also have this as part of the openAPI schema of the Revision (and Service and Configuration). Maybe we can generate something from that?

[evankanderson]

Fixing #3523 would close this issue, and may be the fastest path to be able to do so on an ongoing basis.

[abrennan89]

I think we should close this one since it seems that #3523 supersedes it, and it has been open for over 1.5 years with no meaningful action or eng input provided to create docs. Please bring the discussion to the DUX WG if you feel that there's something important stemming from this that needs to be raised.