Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenAPI docs to generate reference docs #3523

Open
evankanderson opened this issue May 3, 2021 · 4 comments
Open

Use OpenAPI docs to generate reference docs #3523

evankanderson opened this issue May 3, 2021 · 4 comments
Labels
kind/infrastructure Docs infrastructure related kind/needs-automation Tag for issues that involve automation of a task lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/medium triage/needs-eng-input Engineering input is requested
Milestone

Comments

@evankanderson
Copy link
Member

Expected Behavior

https://knative.dev/docs/reference/api/ are based on the exported OpenAPI definitions:

These should be able to be filtered by API group, so only non-internal APIs are documented. Kubernetes has a tool for this here: https://github.com/kubernetes-sigs/reference-docs Documentation on its use is here: https://kubernetes.io/docs/contribute/generate-ref-docs/kubernetes-api/

Actual Behavior

We use the script here: https://github.com/knative/docs/blob/main/hack/gen-api-reference-docs.sh, which uses the custom tool here: https://github.com/ahmetb/gen-crd-api-reference-docs

This builds output based on the Go structures, ignoring any OpenAPI validation or fields that we don't support. Also, the resulting output bleeds through Go structure embedding, making it harder for non-Go developers to understand the shape of the API.

Steps to Reproduce the Problem

  1. Follow directions here: https://knative.dev/help/maintainer/building-api-output/

Additional Info

This is not high-priority at the moment, but since the OpenAPI docs are clearer about which fields are and are not supported, this would fix #2085

@abrennan89 abrennan89 added kind/infrastructure Docs infrastructure related kind/needs-automation Tag for issues that involve automation of a task lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/medium triage/needs-eng-input Engineering input is requested labels Jun 25, 2021
@abrennan89 abrennan89 added this to the Backlog milestone Jun 25, 2021
@abrennan89
Copy link
Contributor

@evankanderson is the plan still to implement this? Any updates?

@abrennan89
Copy link
Contributor

Closing this issue since there's been no work on it and I don't think there's anyone who wants to own this. Also, the related issue mentioned in the description is now closed.
@evankanderson feel free to reopen if you plan to work on this.

@nak3
Copy link
Contributor

nak3 commented Mar 12, 2023

/reopen

knative/serving#12410 (comment) got the request which is most probably same with here.

@knative-prow knative-prow bot reopened this Mar 12, 2023
@knative-prow
Copy link

knative-prow bot commented Mar 12, 2023

@nak3: Reopened this issue.

In response to this:

/reopen

knative/serving#12410 (comment) got the request which is most probably same with here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/infrastructure Docs infrastructure related kind/needs-automation Tag for issues that involve automation of a task lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/medium triage/needs-eng-input Engineering input is requested
Projects
None yet
Development

No branches or pull requests

3 participants