Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for DeliverySpec.Timeout #3793

Merged
merged 4 commits into from
Jun 24, 2021
Merged

Documentation for DeliverySpec.Timeout #3793

merged 4 commits into from
Jun 24, 2021

Conversation

slinkydeveloper
Copy link
Contributor

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Proposed Changes

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 14, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 14, 2021
@slinkydeveloper
Copy link
Contributor Author

/hold

This is ready for review but the approval requires the approval of knative/eventing#5148 first

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2021
@netlify
Copy link

netlify bot commented Jun 14, 2021 •
edited
Loading

✔️ Deploy Preview for dev-knative ready!

🔨 Explore the source changes: 8b02200

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60d03543f84f1d0007fa8583

😎 Browse the preview: https://deploy-preview-3793--dev-knative.netlify.app/development/eventing/experimental-features

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2021
@slinkydeveloper
Delivery.Timeout
3bfecd1 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
State -> Stage
cd01d9b 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2021
@slinkydeveloper
Trailing WS
8b02200 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper mentioned this pull request Jun 22, 2021
Open
8 tasks
@slinkydeveloper
Copy link
Contributor Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2021
@slinkydeveloper
Copy link
Contributor Author

@abrennan89 can you check this out?

abrennan89
abrennan89 suggested changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

@slinkydeveloper
Copy link
Contributor Author

/hold

Let's wait for knative/eventing#5507 to be merged first

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2021
@slinkydeveloper
Suggestions
6510a84 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@abrennan89
Copy link
Contributor

/retest

abrennan89
abrennan89 approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2021
@slinkydeveloper
Copy link
Contributor Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2021
@knative-prow-robot knative-prow-robot merged commit af0c10b into knative:mkdocs Jun 24, 2021
@slinkydeveloper slinkydeveloper deleted the delivery-timeout branch June 24, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrennan89 abrennan89 abrennan89 approved these changes

Assignees

@abrennan89 abrennan89

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slinkydeveloper @abrennan89 @knative-prow-robot