Glue Delivery.Timeout to RetryConfig.RequestTimeout

[slinkydeveloper]

Part of #5148

Depends on #5149 and #5503

Proposed Changes

• 🎁 Glue Delivery.Timeout to RetryConfig.RequestTimeout
• 🎁 e2e test for delivery.timeout

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact: Details in the issue
• Spec PR for any new API feature: N/A
• Conformance test for any change to the spec: N/A

[slinkydeveloper]

Note: this PR is a merge of #5149 and #5503, just look from the commit 3456a3f onward (I'll rebase this PR once the previous 2 are merged)

/hold

This requires the lazy consensus approval per https://github.com/knative/eventing/blob/main/docs/experimental-features.md#feature-proposal-development-and-graduation-process

[codecov]

Codecov Report

Merging #5507 (36a5b01) into main (a02a8f2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5507      +/-   ##
==========================================
+ Coverage   82.61%   82.63%   +0.01%     
==========================================
  Files         198      198              
  Lines        6144     6151       +7     
==========================================
+ Hits         5076     5083       +7     
  Misses        741      741              
  Partials      327      327              

Impacted Files	Coverage Δ
pkg/channel/fanout/fanout_message_handler.go	88.05% <ø> (ø)
pkg/kncloudevents/retries.go	86.36% <100.00%> (+1.74%)	⬆️
pkg/reconciler/subscription/subscription.go	79.21% <100.00%> (+0.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a02a8f2...36a5b01. Read the comment docs.

[slinkydeveloper]

/unhold

https://groups.google.com/g/knative-dev/c/7h1p0eBmUuo/m/lTzaSULKAQAJ

[matzew]

looks like some conformance tests are failing here

[slinkydeveloper]

Works fine, let's retest once more

/test pull-knative-eventing-unit-tests

[slinkydeveloper]

cc @matzew

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kncloudevents/retries.go	93.9%	94.7%	0.8
pkg/reconciler/subscription/subscription.go	85.3%	85.4%	0.1

[slinkydeveloper]

/retest

[matzew]

/lgtm
/approve

glad the tests are now back!

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [matzew,slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment