Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delivery timeout #5149

Merged
merged 8 commits into from
Jun 22, 2021
Merged

Delivery timeout #5149

merged 8 commits into from
Jun 22, 2021

Conversation

slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented Mar 25, 2021 •
edited
Loading

Fixes #5148

Proposed Changes

  • 🎁 Added DeliverySpec.Timeout

Release Note

Added `DeliverySpec.Timeout`

Docs

I'm going to create the docs as soon as we implement this in our components

Spec PR: knative/specs#15

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 25, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 25, 2021
@codecov
Copy link

codecov bot commented Mar 25, 2021 •
edited
Loading

Codecov Report

Merging #5149 (fb56da6) into main (6adafe5) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5149      +/-   ##
==========================================
+ Coverage   82.62%   82.65%   +0.03%     
==========================================
  Files         198      198              
  Lines        6117     6130      +13     
==========================================
+ Hits         5054     5067      +13     
  Misses        737      737              
  Partials      326      326
Impacted Files Coverage Δ
pkg/apis/duck/v1/delivery_types.go 91.66% <100.00%> (+3.43%) ⬆️
pkg/apis/duck/v1beta1/delivery_conversion.go 100.00% <100.00%> (ø)
pkg/apis/duck/v1beta1/delivery_types.go 90.47% <100.00%> (+2.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6adafe5...fb56da6. Read the comment docs.

@slinkydeveloper
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2021
This was referenced Mar 25, 2021
Closed
Open
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2021
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 8, 2021
@slinkydeveloper
Copy link
Contributor Author

/hold

This requires the lazy consensus approval per https://github.com/knative/eventing/blob/main/docs/experimental-features.md#feature-proposal-development-and-graduation-process

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2021
@slinkydeveloper slinkydeveloper mentioned this pull request Jun 14, 2021
Merged
5 tasks
@matzew
Copy link
Member

matzew commented Jun 14, 2021

LGTM

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2021
@slinkydeveloper
Added DeliverySpec.Timeout
22951b5 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
codegen
803713e 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Yamls
5825f06 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Added the feature flag
7df4e62 
Fixed validation
Fixed CRD

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Fix validation UT
291b51c 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Added comment
2461bc7 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Specify the value has to be greater than 0
94a9dfa 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2021
@slinkydeveloper
Update docs
fb56da6 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/duck/v1/delivery_types.go 93.3% 95.2% 1.9
pkg/apis/duck/v1beta1/delivery_types.go 93.3% 94.7% 1.4

@slinkydeveloper
Copy link
Contributor Author

slinkydeveloper commented Jun 22, 2021 •
edited
Loading

/unhold

https://groups.google.com/g/knative-dev/c/7h1p0eBmUuo/m/lTzaSULKAQAJ

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2021
matzew
matzew approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [matzew,slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 9cd2858 into knative:main Jun 22, 2021
@slinkydeveloper slinkydeveloper deleted the delivery_timeout branch June 22, 2021 09:30
@devguyio devguyio mentioned this pull request Sep 9, 2021
Merged
5 tasks
@lionelvillard lionelvillard mentioned this pull request Sep 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi left review comments

@n3wscott n3wscott n3wscott left review comments

@matzew matzew matzew approved these changes

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Experimental] DeliverySpec Timeout
6 participants
@slinkydeveloper @matzew @knative-metrics-robot @knative-prow-robot @n3wscott @pierDipi