Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout experimental feature to the spec #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lionelvillard
Copy link
Member

Added timeout to the delivery spec. For more details: knative/eventing#5149

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lionelvillard
To complete the pull request process, please assign bsnchan after the PR has been reviewed.
You can assign the PR to them by writing /assign @bsnchan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 27, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 27, 2021
@evankanderson
Copy link
Member

I think we may want to have a bit of a level-setting discussion here; the goal of the specs repo is to have a minimal, useful specification for what a conformant implementation looks like, rather than to document every behavior of the current OSS implementation.

I suspect that we may want to remove the "update the spec" suggestion in the eventing template, as the goal is that the Knative spec evolves more slowly than the OSS implementation, which can make experimental and backwards-incompatible changes without requiring a new spec release and vendors to update their software in order to maintain conformance.

@evankanderson
Copy link
Member

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2021
<tr>
<td><code>timeout</code></td>
<td>string (OPTIONAL)</td>
<td>The timeout of each single request.</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description should indicate what the acceptable values of the string are. Is "a score of fortnights" acceptable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serving has a timeoutSeconds integer. Any particular reason to use a different type and name?

@dprotaso
Copy link
Member

@pierDipi is this still relevant?
/unassign @evankanderson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants