-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RetryConfig.RequestTimeout to configure the timeout of a single request #5503
RetryConfig.RequestTimeout to configure the timeout of a single request #5503
Conversation
/hold This requires the lazy consensus approval per https://github.com/knative/eventing/blob/main/docs/experimental-features.md#feature-proposal-development-and-graduation-process |
Codecov Report
@@ Coverage Diff @@
## main #5503 +/- ##
==========================================
+ Coverage 82.56% 82.58% +0.01%
==========================================
Files 198 198
Lines 6125 6131 +6
==========================================
+ Hits 5057 5063 +6
Misses 741 741
Partials 327 327
Continue to review full report at Codecov.
|
the verify was recently (no idea why) also failing a few times for me |
Let me try to rebase |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
7e1150c
to
407cd61
Compare
The following is the coverage report on the affected files.
|
@matzew now it pass :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Part of #5148
Proposed Changes
RetryConfig.RequestTimeout
to configure the timeout of a single request when usingkncloudevents.HTTPMessageSender
Pre-review Checklist