Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RetryConfig.RequestTimeout to configure the timeout of a single request #5503

Merged

Conversation

slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented Jun 14, 2021

Part of #5148

Proposed Changes

  • 🎁 Add RetryConfig.RequestTimeout to configure the timeout of a single request when using kncloudevents.HTTPMessageSender

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior: N/A
  • Docs PR for any user-facing impact: N/A
  • Spec PR for any new API feature: N/A
  • Conformance test for any change to the spec: N/A

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 14, 2021
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 14, 2021
@slinkydeveloper
Copy link
Contributor Author

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2021
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #5503 (407cd61) into main (b312f0e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5503      +/-   ##
==========================================
+ Coverage   82.56%   82.58%   +0.01%     
==========================================
  Files         198      198              
  Lines        6125     6131       +6     
==========================================
+ Hits         5057     5063       +6     
  Misses        741      741              
  Partials      327      327              
Impacted Files Coverage Δ
pkg/kncloudevents/retries.go 84.61% <ø> (ø)
pkg/kncloudevents/message_sender.go 89.65% <100.00%> (+2.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b312f0e...407cd61. Read the comment docs.

@slinkydeveloper
Copy link
Contributor Author

slinkydeveloper commented Jun 22, 2021

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2021
@matzew
Copy link
Member

matzew commented Jun 22, 2021

the verify was recently (no idea why) also failing a few times for me

@slinkydeveloper
Copy link
Contributor Author

Let me try to rebase

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper force-pushed the delivery_timeout_kncloudevents branch from 7e1150c to 407cd61 Compare June 22, 2021 08:49
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kncloudevents/message_sender.go 85.7% 88.2% 2.5

@slinkydeveloper
Copy link
Contributor Author

@matzew now it pass :)

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [matzew,slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit a02a8f2 into knative:main Jun 22, 2021
@slinkydeveloper slinkydeveloper deleted the delivery_timeout_kncloudevents branch June 22, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants