-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Installation Doc Updates #6395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation Doc Updates #6395
Conversation
Improve installation guidance
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the presentation. A few details to adjust:
- We have 3 install options. Quickstart creates a local-only install, while you can either use YAML files or the Operator, depending on how you like to control installation on your cluster.
- Install should work for all three platforms -- Mac, Windows, and Linux. We assume the target cluster is running Linux, but you can use
kind/minikubelocally with any platform to get a Linux Kubernetes cluster.
link fix Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
link fix Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
More writing
Misc edits
Minor edits
Consolidating CLI installations into this this topic.
Changing red bug alert to important The old syntax was: ??? bug "Having issues upgrading `kn` to Homebrew?"
Removed alert formatting
Various edits
Made Evan suggestions, table column test, spelling fixes
link fix
Replaced the table with a bulleted list approach.
Put back the table
Updated topics per effort - consolidating guidance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking quite improved, thank you!
A few notes -- do you have an idea when this will be ready to merge? (In particular, do you have more content you want to add to this PR, or mostly polishing the current contents?)
docs/install/yaml-install/eventing/install-eventing-with-yaml.md
Outdated
Show resolved
Hide resolved
Thanks Evan! Just a few more pushes to warp up this PR with the following:
Then in a following PR, I'll add that macro magic to get binaries more easily. |
All files added for this PR.
|
I'd like to merge #6398 soon, which will conflict with this PR. I'm happy to let this PR merge first if it will be done in the next day or so -- otherwise, I may ask you to handle the merge so that I can work on backporting those changes. |
No problem. I'm in touch ups now and will be done within the hour. |
|
OK to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
I'd like to trim the operator stuff in the client/ section, personally, but I can understand how it got in there, since the operator subcommand is part of the kn plugin experience (as is func, which we don't mention, and a few other plugins).
| --- | ||
|
|
||
| # Install Knative using quickstart | ||
| # Install the Knative quickstart plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This topic covers both installing the plugin, and using the plugin to get a cluster with Knative installed on it.
Maybe just "quickstart" or "quickstart install"?
|
|
||
| - Kubernetes CLI - `kubectl` | ||
| - Knative CLI - `kn` | ||
| - Knative Operator CLI - `kn` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The operator is part of the Knative CLI, but is primarily focused on administrators who have whole-cluster control. I think this documentation should be focused on developers, and we should leave out the operator bits.
|
|
||
| See the [Tekton documentation](http://hub.tekton.dev/tekton/task/kn){target=_blank}. | ||
|
|
||
| ## Install the Knative Operator CLI Plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with leaving a note here (though it seems odd that we mention the administrator-focused operator plugin but not the developer-focused func plugin), but this section should make it clear that the operator subcommands are mostly useful for cluster administrators, rather than average developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Let's find a better place for the Operator content in a subsequent PR.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, iRaindrop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
|
/lgtm |
* Installation Doc Updates Improve installation guidance * Formatting fix * Update docs/install/README.md link fix Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> * Update docs/install/README.md link fix Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> * link fix and table update More writing * Update README.md Misc edits * Update README.md Minor edits * Adding install-kn to PR Consolidating CLI installations into this this topic. * Update install-kn.md Changing red bug alert to important The old syntax was: ??? bug "Having issues upgrading `kn` to Homebrew?" * Update install-kn (snippet) Removed alert formatting * Added quickstart-install.md Various edits * Fixes and reviewed edits Made Evan suggestions, table column test, spelling fixes * Update quickstart-install.md link fix * Update README.md Replaced the table with a bulleted list approach. * Update README.md Put back the table * Added serving and eventing install topics Updated topics per effort - consolidating guidance * Link fixes * Made Evan's edits * Various updates All files added for this PR. * Link fix * Formatting fixes * Formatting and consistency fix * Update docs/install/operator/knative-with-operator-cli.md Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> * Update docs/client/install-kn.md Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> --------- Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
* Phase 1: Adding documentation metadata tags (#6274) * Add metadata tags for documentation * Add classification for about 2/3rds of docs (func + eventing) * Add classification for remainder of docs (serving+install) * Add mermaid support (#6327) * Publish threat model in documentation (#6263) * Publish threat model in documentation * Separate security contents a bit more, update link to threat model, update nav * Add a section on supply chain and SBOM/SLSA mitigation * Update threat model with feedback from David Hadas * Update introduction with content from davidhadas, add sections on controller and webhook functionality and update targets of threats * content tab fixes, added success output for kn func (#6367) * Add dry run section and take out old feature flag in serving (#6366) * add dry run section * drop mention of old feature flag * fix casing on nav * update docs to be more clear and include inline example --------- Co-authored-by: Dave Protasowski <dprotaso@gmail.com> * Attempt to rebuild docs build process, inspired by #6319 (#6371) * Attempt to rebuild docs build process * Use a more modern python version * Fix strict verify, hide versions on unversioned pages * Fix search with mkdocs typescript patches (vendored). (#6392) Hopefully, this can be fixed upstream via PR shortly. * Installation Doc Updates (#6395) * Installation Doc Updates Improve installation guidance * Formatting fix * Update docs/install/README.md link fix Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> * Update docs/install/README.md link fix Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> * link fix and table update More writing * Update README.md Misc edits * Update README.md Minor edits * Adding install-kn to PR Consolidating CLI installations into this this topic. * Update install-kn.md Changing red bug alert to important The old syntax was: ??? bug "Having issues upgrading `kn` to Homebrew?" * Update install-kn (snippet) Removed alert formatting * Added quickstart-install.md Various edits * Fixes and reviewed edits Made Evan suggestions, table column test, spelling fixes * Update quickstart-install.md link fix * Update README.md Replaced the table with a bulleted list approach. * Update README.md Put back the table * Added serving and eventing install topics Updated topics per effort - consolidating guidance * Link fixes * Made Evan's edits * Various updates All files added for this PR. * Link fix * Formatting fixes * Formatting and consistency fix * Update docs/install/operator/knative-with-operator-cli.md Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> * Update docs/client/install-kn.md Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> --------- Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> * Fix edit page links, move technical docs under sub-heading (#6398) * Fix edit links by moving docs content under a dedicated subdirectory * Fix edit links by moving docs content under a dedicated subdirectory * Add High availability documentation section for eventing (#6401) I have copy-pasted from the Knative Serving documentation page the block as I found it missing when configuring it. * Update proc-running-function.md (#6400) Undo separeate kn func output for invoke * Add a note that Apache Kafka is required to use EKB (#6404) * Move install docs to administration (#6403) * Fix trailing newline complaints * Fix redirects from #6398 --------- Co-authored-by: Bruce Hamilton <scarlettbernique@gmail.com> Co-authored-by: Alexander-Kita <Alexander.Kita@ibm.com> Co-authored-by: Dave Protasowski <dprotaso@gmail.com> Co-authored-by: Aurélien Joga <aurelienjoga+ajoga@gmail.com> Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
Improve installation guidance
iRaindrop = Bruce Hamilton bhamilton@expertsupport.com
Provide roadmap guidance for installing Knative, make improvements and consistencies.
Proposed Changes